From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6CEBC1FF187 for ; Mon, 11 Aug 2025 22:33:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9926A3D4F1; Mon, 11 Aug 2025 22:34:46 +0200 (CEST) Date: Mon, 11 Aug 2025 21:34:34 +0100 To: Fiona Ebner , Proxmox VE development discussion References: In-Reply-To: MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Joao Sousa via pve-devel Precedence: list Cc: Joao Sousa X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH qemu-server 0/2] set write threshold logic Content-Type: multipart/mixed; boundary="===============5747854632338310482==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============5747854632338310482== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2B58ED43F2 for ; Mon, 11 Aug 2025 22:34:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF0E23D520 for ; Mon, 11 Aug 2025 22:34:44 +0200 (CEST) Received: from eurotux.com (mail.eurotux.com [185.98.249.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Aug 2025 22:34:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by eurotux.com (Postfix) with ESMTP id DA5F530CC01B; Mon, 11 Aug 2025 21:34:35 +0100 (WEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eurotux.com; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id; s=default; t= 1754944475; x=1756758876; bh=MJU1dsLHUX40oveIiIELzB5TfcCSCA192ZM vz+mlvFY=; b=5FEIDYR/LWPUzYrgAoc/43kNdZfwDcy/lsI1xJyrNO3xf/sPeZS y+mqCDnil6ERr9oSLG4pdoi8uuxoI3lE40MwX4C+yp7ypE1Lx7pBm2IIqBprIen+ WBtNzqXld3SFxcVw4VMZiH0zJ4zy3rjfI2mZe5kZ9gtNAhDCqxO6IBH7WLAb6kh9 YBBAWzND5mQHsPSELcNKnmgSeDQ/Evmk9qP33ebYFzjHSXB8kQ1pzcd5kpS2uhOu slejiiWNo+GvQ9jLZ7C+LpPk2nVNAwrnykLudX1TeZ6VQ9fLCGv1tnQAwkVmAC9B 06W8N5AHMqdOkURnQdu8SZWbdSMLjcM4FFg== X-Virus-Scanned: amavisd-new at mail.prd.eurotux.pt Received: from eurotux.com ([127.0.0.1]) by localhost (mail.prd.eurotux.pt [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 32gPb-ENm-PD; Mon, 11 Aug 2025 21:34:35 +0100 (WEST) Received: from [10.0.0.103] (184.137.90.149.rev.vodafone.pt [149.90.137.184]) (Authenticated sender: joao.sousa@eurotux.com) by eurotux.com (Postfix) with ESMTPSA id 55CAB30CBFF9; Mon, 11 Aug 2025 21:34:35 +0100 (WEST) Message-ID: <65e2f286-320a-435c-9846-24aad68f9db7@eurotux.com> Date: Mon, 11 Aug 2025 21:34:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pve-devel] [PATCH qemu-server 0/2] set write threshold logic To: Fiona Ebner , Proxmox VE development discussion References: Content-Language: en-US From: Joao Sousa In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_MSPIKE_H2 -0.01 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record On 8/4/25 10:14 AM, Fiona Ebner wrote: > blockdev_add()/Blockdev::attach() are only called for hot-plugged disks, > not disks already present at start-up time. You either need to set the > threshold as part of the blockdev options in the generate_*_blockdev() > functions (if that is possible, would be preferred) or issue the QMP > commands for the initially present disks right after VM start (in > vm_start_nolock(), we already do something similar for ballooning). AFAIK the write threshold cannot be set when the blockdev is created, at least for now. As you suggested, I was able to loop over every volume in vm_start_lock() and the threshold is being set correctly. Thanks! Best regards, Tiago --===============5747854632338310482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============5747854632338310482==--