From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id E8D1D1FF161
for <inbox@lore.proxmox.com>; Tue, 5 Nov 2024 01:53:59 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 24BA415B33;
Tue, 5 Nov 2024 01:54:07 +0100 (CET)
Date: Tue, 5 Nov 2024 13:53:41 +1300
To: a.lauterer@proxmox.com
References: <20241004050957.441759-1-severen.redwood@sitehost.co.nz>
<20241004050957.441759-4-severen.redwood@sitehost.co.nz>
<0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com>
In-Reply-To: <0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.711.1730768045.332.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Severen Redwood via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Severen Redwood <severen.redwood@sitehost.co.nz>,
pve-devel@lists.proxmox.com, t.lamprecht@proxmox.com
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] [PATCH container v2] api: record CT ID as used
after a container is destroyed
Content-Type: multipart/mixed; boundary="===============1337031025084426675=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
--===============1337031025084426675==
Content-Type: message/rfc822
Content-Disposition: inline
Return-Path: <severen.redwood@sitehost.co.nz>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2FF53CA3E9
for <pve-devel@lists.proxmox.com>; Tue, 5 Nov 2024 01:54:05 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0FF0215B0D
for <pve-devel@lists.proxmox.com>; Tue, 5 Nov 2024 01:54:05 +0100 (CET)
Received: from mx3.ext.sitehost.co.nz (mx3.ext.sitehost.co.nz [120.138.20.239])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 5 Nov 2024 01:54:03 +0100 (CET)
Received: from localhost (extmx1-new.vps.sitehost.co.nz [127.0.0.1])
by mx3.ext.sitehost.co.nz (Postfix) with ESMTP id AA9EB180778;
Tue, 5 Nov 2024 13:53:54 +1300 (NZDT)
X-Virus-Scanned: SiteHost Virus/Spam Prevention on mx3.ext.sitehost.co.nz
X-Spam-Flag: NO
X-Spam-Score: -3.45
X-Spam-Status: No, score=-3.45 tagged_above=-100 required=5
tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, RP_MATCHES_RCVD=-0.55]
autolearn=ham autolearn_force=no
Received: from mx3.ext.sitehost.co.nz ([127.0.0.1])
by localhost (mx3.ext.sitehost.co.nz [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id 1zgD5rh9Kmp3; Tue, 5 Nov 2024 13:53:50 +1300 (NZDT)
Received: from yggdrasill (oep.nct.sitehost.co.nz [120.138.23.30])
by mx3.ext.sitehost.co.nz (Postfix) with ESMTPSA id EA25C180BBF;
Tue, 5 Nov 2024 13:53:48 +1300 (NZDT)
Date: Tue, 5 Nov 2024 13:53:41 +1300
From: Severen Redwood <severen.redwood@sitehost.co.nz>
To: a.lauterer@proxmox.com
Cc: pve-devel@lists.proxmox.com, t.lamprecht@proxmox.com
Subject: Re: [pve-devel] [PATCH container v2] api: record CT ID as used after
a container is destroyed
Message-ID: <ba5t63z7iwekm7iejhguzrjxlnpp2d27a4j7flrdcmxturpkfq@lsioezbx572v>
References: <20241004050957.441759-1-severen.redwood@sitehost.co.nz>
<20241004050957.441759-4-severen.redwood@sitehost.co.nz>
<0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0c3fcb3d-6367-403b-968a-d73042853c33@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.094 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_PASS -0.1 DMARC pass policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
SPF_HELO_PASS -0.001 SPF: HELO matches SPF record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm]
Hi Aaron,
On Thu, Oct 31, 2024 at 06:27:43PM +0100, Aaron Lauterer wrote:
> This is missing a
>
> use PVE::UsedVmidList;
>
> at the top of the file. Otherwise running
>
> pct destroy {vmid}
>
> will result in the following error:
>
> Undefined subroutine &PVE::UsedVmidList::add_vmid called at
> /usr/share/perl5/PVE/API2/LXC.pm line 799.
>
> This doesn't seem to be necessary in the qemu-server repo, but I did not
> investigate further how pulling in dependencies works there.
Thanks for catching this! It's strange that it's not necessary in
`PVE::API2::Qemu`... Either way, I think it makes sense to explicitly use the
module in both files, so I'll update the patches to do that.
Thanks,
Severen
--===============1337031025084426675==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
--===============1337031025084426675==--