From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 66B4F1FF164
	for <inbox@lore.proxmox.com>; Fri, 22 Nov 2024 12:03:33 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 53E9D107BB;
	Fri, 22 Nov 2024 12:03:39 +0100 (CET)
To: pve-devel@lists.proxmox.com
Date: Fri, 22 Nov 2024 20:01:51 +0900
MIME-Version: 1.0
Message-ID: <mailman.572.1732273417.391.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Jing Luo <jing@jing.rocks>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH pve-network] d/control: break the circular
 build-dependency with pve-firewall
Content-Type: multipart/mixed; boundary="===============7719121242125199888=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============7719121242125199888==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <jing@jing.rocks>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id AC08AC8913
	for <pve-devel@lists.proxmox.com>; Fri, 22 Nov 2024 12:03:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 849DF10833
	for <pve-devel@lists.proxmox.com>; Fri, 22 Nov 2024 12:03:07 +0100 (CET)
Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Fri, 22 Nov 2024 12:03:04 +0100 (CET)
Received: from mail-gw3.jing.rocks (localhost [127.0.0.1])
	by mail-gw3.jing.rocks (Proxmox) with ESMTP id 26EFE1C958
	for <pve-devel@lists.proxmox.com>; Fri, 22 Nov 2024 20:02:55 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc
	:cc:content-transfer-encoding:date:from:from:message-id
	:mime-version:reply-to:subject:subject:to:to; s=mail-gw; bh=pebe
	kOI1rbnKMWDpeF9lajHv9PNAvL4FJ4D1IIK4sPg=; b=EeTGQlExyYArxn8d5Q5s
	+SRmRBV46BAu/NeUh3CgQCd6593ZzXZU98cpt6I4FAzqN+XI+o0WIeU+rgDjJ+N4
	msk3SB7DhCWZiHGItizC5Z6SV/6fvZo6CSTn9v/CaUNedZ13Uyjul7eElO7tOi1l
	YMFwPlobCkQiUZ8MR4V5fWzBhNnE8zoa7RLJ3LrEiAt3ISgSG5a7RfTE5nwNLhpu
	Dw+5HiKY4f1JtY3DYH3aZ84/eAJ9UPOLUz/RQF4C4AsuI7X+pOp6m5/sxKifiNaI
	4Q7rO/ppycAGgIQR+4+sLRxY2arcHZE4wbjign8Lwh3NNIGVmd0bjjTD5WfTZgIN
	QA==
Received: from mail.jing.rocks (mail.jing.rocks [IPv6:240b:10:f00:1b00::222])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mail-gw3.jing.rocks (Proxmox) with ESMTPS id 9BE601C957
	for <pve-devel@lists.proxmox.com>; Fri, 22 Nov 2024 20:02:53 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks;
	s=default; t=1732273373;
	bh=hPTB0y0L5bC8F+jHwU5pN+yofk1Ub6X5cyhJ6Co7LdA=;
	h=From:To:Cc:Subject:Date:From;
	b=OlHR4kEc4dGChJGFayk4dAaVisirne4WOrhIAl7rYdmh5M02GMvZFLy52StiFceGv
	 ceoqgzDgW6nFy2IdsH33Jfz0YsGoolvIuHpa9gj/7zEarWolYRilBa9geZhhyS4pae
	 FlEwsx5a7pLVG/uMj5//S+1hXgRsofu5Zlit6anSrub8mPUBPIdERMaMj+oMAwMksX
	 /LcZnSutaZUCvQPNSnns+yPGncRFTzInGpjAZsaawV4NTF1L2qW3eEDgXYX5XGArP1
	 6LvvCoJ3utFkCjrcTW5XN4Zw989gzTTrlJJvMxxBSKhHYY7NjLyxCdTCQMsuHuzCqb
	 lhR1b1pGa2uqA==
Received: from X570AM.jing.rocks (X570AM.jing.rocks [IPv6:240b:10:f00:1b00::7e82])
	(Authenticated sender: jing@jing.rocks)
	by mail.jing.rocks (Postfix) with ESMTPSA id 8CDDA3BA08;
	Fri, 22 Nov 2024 20:02:53 +0900 (JST)
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-network] d/control: break the circular build-dependency with pve-firewall
Date: Fri, 22 Nov 2024 20:01:51 +0900
Message-ID: <20241122110243.1426459-1-jing@jing.rocks>
X-Mailer: git-send-email 2.47.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.002 Adjusted score from AWL reputation of From: address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	KAM_INFOUSMEBIZ          0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
	KAM_OTHER_BAD_TLD        0.75 Other untrustworthy TLDs
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked.  See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record

Currently pve-network has a (versioned) build-dep of pve-firewall, which has
a (versioned) runtime dependency of a newer version of libpve-network-perl,
which is not available because it has not been built. It turns out that
pve-firewall is only needed in testing, so let's only pull it in unless
we don't use the "nocheck" build profile so that we can actually build
pve-network from source.

Fixes: cbc70c81b9a2647a20903b27cabb14c1d6dc6d76
Signed-off-by: Jing Luo <jing@jing.rocks>
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index bb8cef9..9eeacbb 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends: debhelper-compat (= 13),
                libtest-mockmodule-perl,
                perl,
                pve-cluster (>= 8.0.10),
-               pve-firewall (>= 5.1.0~),
+               pve-firewall (>= 5.1.0~) <!nocheck>,
                pve-doc-generator (>= 5.3-3),
                libpve-access-control,
 Standards-Version: 4.6.1
-- 
2.47.0




--===============7719121242125199888==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============7719121242125199888==--