From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 37A0C1FF164
	for <inbox@lore.proxmox.com>; Wed, 23 Oct 2024 18:48:52 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 693FA3194B;
	Wed, 23 Oct 2024 18:49:32 +0200 (CEST)
To: pve-devel@lists.proxmox.com
Date: Wed, 23 Oct 2024 18:48:48 +0200
MIME-Version: 1.0
Message-ID: <mailman.516.1729702171.332.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Tiomet Pelston via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Tiomet Pelston <tiometpelston@gmail.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH common 0/1] fix #5623: ovs other_config set to 0
 not saved in network config
Content-Type: multipart/mixed; boundary="===============7092028918059928951=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============7092028918059928951==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <tiometpelston@gmail.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id A4664C7DF9
	for <pve-devel@lists.proxmox.com>; Wed, 23 Oct 2024 18:49:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 886563186B
	for <pve-devel@lists.proxmox.com>; Wed, 23 Oct 2024 18:49:00 +0200 (CEST)
Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Wed, 23 Oct 2024 18:48:59 +0200 (CEST)
Received: by mail-wr1-x443.google.com with SMTP id ffacd0b85a97d-37d49a7207cso5132505f8f.0
        for <pve-devel@lists.proxmox.com>; Wed, 23 Oct 2024 09:48:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1729702132; x=1730306932; darn=lists.proxmox.com;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=IEEIe13jH9vHAtMu9Sl/In5m3FDIPQPJsIDksATcUZ4=;
        b=jURW8O3OHCFbD1cbNgMGqX5D5YdL/BET+a5NfFujimp46CEBIVziKUDdRv13O9DohR
         6iZzrXaYB3S0Bpc2SPSf2OQo4AQJ5YXEnxZuGIRJ4SPmM/WUu1porZbMNRBuG3p5wwIo
         NZdupTwRkyUIdezZHI/qH5bTPz3+6KCatKXZ04Xk2w57uUJYt6/wGJjMLc6VreAux7zI
         zdrAIL2qcnsTAUmn3T0inZv2a0glsPgPWKGetguS9WcYJIl+xMzE7iLgYnBXA7izGflc
         s+G5mHxLhdKHA2lmrHMIUyZAxGaqyYawk8uMEAEOC5PQ260TIOlGtC4SOspXZYZ9eW4N
         yM8w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1729702132; x=1730306932;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=IEEIe13jH9vHAtMu9Sl/In5m3FDIPQPJsIDksATcUZ4=;
        b=esiC+QD9GVuiGqx9IOQzSERaxi37LHe2a2DEeA0FskFwfjEOl1FC6sZ4IcRyBT+Aez
         f4QfMxkyZmv9OPtUPqo6HuZVghuuL+jrQEO43+6DNtxsjVD3mP3bWRMn9m/3YvlBXL0j
         EcG1h6nIh2WOLbV097rN2d4lzWJIx/GBdfhTC8ezd4ygp2ZcIqgG1zGhZGvK9mPPsQBX
         k6NiG8xNR4DbNpCUUhk9sXZL45yC/dVcy+9ypFFT5IekWa/9Y68uGE4ZvIUVCr0seuiZ
         zFnMau8VfJ46Q6vXUm8yFBIXJnS8D4SVvAZJEdgiJHp+aPSkentujvZm57nuriQzzAip
         72Xw==
X-Gm-Message-State: AOJu0YwN2UP5FjPtAWSCpliWwxjdSCAwsbcWu+YhiI2/REaCOhHSZU6O
	RDWKWsT+1pYmgxLY7ftTNe/TOX8xi5EaW8MJYQ6jmfkK9uAQAIhwmZjVJcDv
X-Google-Smtp-Source: AGHT+IFdcKnxS2uK1US5/Zd3S9JUyP9NVk087vZ7xChp8IvS9UHedt3vFOm9NNTnPp8M5VYGSO1RKQ==
X-Received: by 2002:adf:e848:0:b0:37d:4fe9:b6a4 with SMTP id ffacd0b85a97d-37efcf897aamr2089669f8f.50.1729702131964;
        Wed, 23 Oct 2024 09:48:51 -0700 (PDT)
Received: from localhost.localdomain.misit-augsburg.de (vm210-misit.informatik.uni-augsburg.de. [137.250.168.210])
        by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a37e1asm9308320f8f.20.2024.10.23.09.48.51
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 23 Oct 2024 09:48:51 -0700 (PDT)
From: Tiomet Pelston <tiometpelston@gmail.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH common 0/1] fix #5623: ovs other_config set to 0 not saved in network config
Date: Wed, 23 Oct 2024 18:48:48 +0200
Message-ID: <20241023164849.3027-1-tiometpelston@gmail.com>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	FREEMAIL_FROM           0.001 Sender email is commonly abused enduser mail provider
	RCVD_IN_DNSWL_NONE     -0.0001 Sender listed at https://www.dnswl.org/, no trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [inotify.pm,proxmox.com]

When configuring an OVS network device via web interface, 
setting an OVS option with value=0 will be disregarded on save.

Example:
Create an OVS Bond with the following OVS option:

other_config:bond-rebalance-interval=0

This will be purged from the config although it is a valid setting.
The same happens for any other config like "other_config:<anything>=0".

Further details:
https://forum.proxmox.com/threads/ovs-other_config-set-to-0-gets-filtered-from-network-config.150504/

Tiomet Pelston (1):
  fix #5623: ovs other_config set to 0 not saved in network config

 src/PVE/INotify.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.43.0



--===============7092028918059928951==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============7092028918059928951==--