From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id B47B41FF161
	for <inbox@lore.proxmox.com>; Wed, 20 Nov 2024 17:10:35 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5F65913E24;
	Wed, 20 Nov 2024 17:10:41 +0100 (CET)
Date: Wed, 20 Nov 2024 18:10:01 +0200
To: Max Carrara <m.carrara@proxmox.com>, pve-devel@lists.proxmox.com
References: <b16012bc-d4a9-42ff-b9ba-523649c6cfa6@storpool.com>
 <D4QD7MV07R0N.2YY4SB8VFU3UO@proxmox.com>
In-Reply-To: <D4QD7MV07R0N.2YY4SB8VFU3UO@proxmox.com>
MIME-Version: 1.0
Message-ID: <mailman.509.1732119040.391.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Ivaylo Markov via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Ivaylo Markov <ivaylo.markov@storpool.com>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: Re: [pve-devel] Proposal: support for atomic snapshot of all VM
 disks at once
Content-Type: multipart/mixed; boundary="===============8387723000431357662=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

This is a multi-part message in MIME format.
--===============8387723000431357662==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <ivaylo.markov@storpool.com>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id 6621EC7AB1
	for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:10:40 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 4430613DA6
	for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:10:10 +0100 (CET)
Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 17:10:09 +0100 (CET)
Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a9ed49edd41so428806866b.0
        for <pve-devel@lists.proxmox.com>; Wed, 20 Nov 2024 08:10:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=storpool.com; s=google; t=1732119003; x=1732723803; darn=lists.proxmox.com;
        h=in-reply-to:organization:from:content-language:references:to
         :subject:user-agent:mime-version:date:message-id:from:to:cc:subject
         :date:message-id:reply-to;
        bh=33xoAPyxxFgEe9MW2ejfGO82bytRi6nuSaSoCbGWV1Y=;
        b=OIb+/WPUsxGsNSVP3IXGhoaeKMFwMGxEYaKrpOmlpSfr8Ir2594HcEa975wN7N90M8
         KDFQEMneV5bQK2VLmVzJaRQJ/kUtsQ6N+nw5ZCyTCAgOZtozamEpXQAkvea6N3RlQKH1
         h0ByMErBzqjWjWWIPVyel82oYmBzuXhjZ0eDM6Wuo4A3CjMMWGA5YASAx1H74DoYcwsf
         1rp6UZxuuvlhv018DijXh7Zdl+2PQGguoajy4lttttMVfRsJB1EdzsXnKrtjt+GsP+sM
         xutxVZPGBUiEojbvfSteAXk2SKkfNEpGDgb1KLTt2KdH2vVuW/mCPViWHTOCQM9z9O35
         xUMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1732119003; x=1732723803;
        h=in-reply-to:organization:from:content-language:references:to
         :subject:user-agent:mime-version:date:message-id:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to;
        bh=33xoAPyxxFgEe9MW2ejfGO82bytRi6nuSaSoCbGWV1Y=;
        b=QAeNtj+YenlEWgKoc2k38+WdQq97VSx7virmQcm4/7mqK7r8L8PNc1gd/gdkoXrE5j
         A7SG1Imw8QnTArm0jSdeNSKJxhMiq6dhJG3f9z3FkAlgBik19+8jZ06VZp6CYKsL2mVW
         MyBosiq6oKES8HD9BIPZ3xagkqz2L32Tkk/hRPsCJi+Sht2Y6qqRgBfyrM97cfXtvuxO
         39Il0BlQZh6QKrMSwg3liWRdIF3kRF85ywD8jWbnv2UigckCeWuiVEuin/XWRsn4X1vY
         uqPYSpse+HrL1xeDMkNnwxNu6vgtBKRyk39CXE69sLm4+U7sKxUXo65yN5uYG6YyPXv7
         yg5Q==
X-Forwarded-Encrypted: i=1; AJvYcCV9kj9cy3eoFr/4HODu+1I9L2UUuJnFR/F/xPUS69ezY/68KmihqpLim0vR3AgL4dEnNK6CQU98XZk=@lists.proxmox.com
X-Gm-Message-State: AOJu0YzV5qIAzAUFwKixxfLfHYAnN0t2mLcdwaoViIjrjTnMbRtbZX9R
	Boh9io/hiXxNmc6Pn40730jJ1EDHmUYPIzIe+8yv8WRLmtbUtnJjLAkZWGW4/PnO4T4jBkSrdps
	SFHE=
X-Gm-Gg: ASbGnctLqlGmH4I9Z7Wyw1zYL3GUBi6YTBuT3M/qIO5/vAjvUF5XlWXVS2uWs5aqxBV
	60AzKvbUaDMMydIpvbL17mV1Q0pjBJH7fqD4lH17W2p6uyWX/QIGwjhD81c2QiFQy9OUeXX/AjG
	WruyPdFcjrD8KQRHtkbPrhSNat151H9GtQskkrxSLRe6nwgATI/XI97GgjwPY4qzmyMrpxOPZk4
	QDXWe7MztJfd1++xbQ1bYbOnybCMzXBgxmSYTpkmg1UqPv83q5brs9bY4sA9ozIVFFvRRq3+lgN
	CK52KIJQKGxW4WCHP0mxIsM=
X-Google-Smtp-Source: AGHT+IG4h5hcCW7auQUZai0C5+QGb/XJ7pBPqC1ydPv+cEVB52jkgWE//jHT6R3z6i5C2Oc+yLXeWg==
X-Received: by 2002:a17:907:9452:b0:a9a:67a9:dc45 with SMTP id a640c23a62f3a-aa4dd50a559mr353302766b.3.1732119002909;
        Wed, 20 Nov 2024 08:10:02 -0800 (PST)
Received: from ?IPV6:2001:67c:21bc:e:2fef:78a4:17e9:f4b8? ([2001:67c:21bc:e:2fef:78a4:17e9:f4b8])
        by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20df50ab9sm784177366b.51.2024.11.20.08.10.02
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Wed, 20 Nov 2024 08:10:02 -0800 (PST)
Message-ID: <de35bf0d-5637-40a5-8286-a391807ab1d9@storpool.com>
Date: Wed, 20 Nov 2024 18:10:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Proposal: support for atomic snapshot of all VM disks at once
To: Max Carrara <m.carrara@proxmox.com>, pve-devel@lists.proxmox.com
References: <b16012bc-d4a9-42ff-b9ba-523649c6cfa6@storpool.com>
 <D4QD7MV07R0N.2YY4SB8VFU3UO@proxmox.com>
Content-Language: en-US
From: Ivaylo Markov <ivaylo.markov@storpool.com>
Organization: StorPool Storage
In-Reply-To: <D4QD7MV07R0N.2YY4SB8VFU3UO@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.001 Adjusted score from AWL reputation of From: address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	HTML_MESSAGE            0.001 HTML included in message
	RCVD_IN_DNSWL_NONE     -0.0001 Sender listed at https://www.dnswl.org/, no trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storpool.com]
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29

Hello,

I've been caught up in other things and it's been a while, but as I was 
collating and testing my proposed changes, I came across this again and 
thought I'd clarify something.

On 08/10/2024 13:50, Max Carrara wrote:
>> I was directed here to discuss this proposal and my implementation idea
>> after an initial post in Bugzilla[1]. The goal is to give storage
>> plugins the option to perform atomic crash-consistent snapshots of the
>> virtual disks associated with a virtual machine where the backend
>> supports it  (e.g. Ceph, StorPool, and ZFS) without affecting those
>> without such a feature.
> Since you mentioned that the backends without such a feature won't be
> affected, will the disks of the storage types that *do* support it still
> be addressable individually? As in: Would it be possible to run both
> group snapshots and individual snapshots on a VM's disks? (I'm assuming
> that they will, but still wanted to ask.)
>
Do you mean this this as "you can snapshot the whole VM (all disks) at 
once *or* each disk individually" or "when making a snapshot of the 
entire VM, the user can chose between individual/group snapshot of all 
drives". What I have so far matches the first description, but I just 
realized you might have meant the second one, so I thought I'd ask and 
potentially create more work for myself :)

-- 
Ivaylo Markov
Quality & Automation Engineer
StorPool Storage
https://www.storpool.com

--===============8387723000431357662==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============8387723000431357662==--