From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id D79AE1FF390
	for <inbox@lore.proxmox.com>; Fri,  7 Jun 2024 13:01:03 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id A45F71D51D;
	Fri,  7 Jun 2024 13:01:23 +0200 (CEST)
To: pve-devel@lists.proxmox.com
Date: Fri,  7 Jun 2024 18:43:23 +0900
X-Mailman-Approved-At: Fri, 07 Jun 2024 13:01:21 +0200
MIME-Version: 1.0
Message-ID: <mailman.483.1717758081.319.pve-devel@lists.proxmox.com>
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
From: Jing Luo via pve-devel <pve-devel@lists.proxmox.com>
Precedence: list
Cc: Jing Luo <jing@jing.rocks>
X-Mailman-Version: 2.1.29
X-BeenThere: pve-devel@lists.proxmox.com
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
Subject: [pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a
 data type
Content-Type: multipart/mixed; boundary="===============2646563350227714028=="
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

--===============2646563350227714028==
Content-Type: message/rfc822
Content-Disposition: inline

Return-Path: <jing@jing.rocks>
X-Original-To: pve-devel@lists.proxmox.com
Delivered-To: pve-devel@lists.proxmox.com
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by lists.proxmox.com (Postfix) with ESMTPS id 84EDCC8893
	for <pve-devel@lists.proxmox.com>; Fri,  7 Jun 2024 11:47:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 62C751C266
	for <pve-devel@lists.proxmox.com>; Fri,  7 Jun 2024 11:47:58 +0200 (CEST)
Received: from mail-gw3.jing.rocks (mail-gw3.jing.rocks [219.117.250.209])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by firstgate.proxmox.com (Proxmox) with ESMTPS
	for <pve-devel@lists.proxmox.com>; Fri,  7 Jun 2024 11:47:56 +0200 (CEST)
Received: from mail-gw3.jing.rocks (localhost [127.0.0.1])
	by mail-gw3.jing.rocks (Proxmox) with ESMTP id 2AF6A161BB
	for <pve-devel@lists.proxmox.com>; Fri,  7 Jun 2024 18:47:54 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jing.rocks; h=cc
	:cc:content-transfer-encoding:date:from:from:message-id
	:mime-version:reply-to:subject:subject:to:to; s=mail-gw; bh=q9DS
	RQHuOAebvjF3BdQk5EfJGv62oQsI8n8DdCS9s0o=; b=cCDvKfn5X+mY+QU/HW7N
	GNW5ytxWEsE8gJr2vl5qAoKTh4kkGLM7t5fCyfB2//Qa5RCqTUaXTDaF8PPN5M3d
	DvQHRGmmjjm97kiNX3WjTefbIMmWBaeswPyUz6lmOL7i76Nyux2OFfJdgLT/clJV
	TCFDx14pF/5S3+tZqQZd48ewIb+1akmjQnJ73rSRNIcuUE2qR4A7WLlJR4g1oi2m
	HGQ2niZT61879GYz4HopwFTmOvvzNZte+P/8NYKw9MCyQ7SL4Jp1dNQVAD+yMDUv
	nOvPdHZKIIdaaQ470l1AH9atjAcAAkQXHD791orVn8jRAOHAdVuuWFpqJ2c62sqr
	hg==
Received: from mail.jing.rocks (mail.jing.rocks [IPv6:240b:10:f00:1b00::222])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mail-gw3.jing.rocks (Proxmox) with ESMTPS id 46894161B6
	for <pve-devel@lists.proxmox.com>; Fri,  7 Jun 2024 18:47:51 +0900 (JST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jing.rocks;
	s=default; t=1717753671;
	bh=9Q9ZoLFbJUjPg5ij538cqgVql8CcM1enpR4gm3S9ZH4=;
	h=From:To:Cc:Subject:Date:From;
	b=Yqn4tJ1bzLtyTQ5nJTszyLg5m9LPENH/C2BV2veNn6O1kZqC9ircTqMCotHE/QlDd
	 omI70FnCD6cY5r+iAnUAlDC1TRUkEyzFjlaLGjecHBtX4zLexcaig3xCufM51NEwbC
	 cZEQE40U9EyA9eifHy3TFwwgKLjJSOJqzo28uBx7l4iQvY7fG2jJdJcM8SfJLapAMs
	 0VPoVYMa9nqOdNh5R+Umrzhx6qK5enrS59qodvtqMvkHGOY+1yBhTors6Y125w88Yx
	 zcTWlSGMMUH1th8iyStvbEYSMBCQkp4AlukQ9MdmXchBJNQwAl78351clHmxc44JM6
	 Tur5TvuaElzIA==
Received: from X570AM.jing.rocks (unknown [IPv6:240b:10:f00:1b00::7e82])
	(Authenticated sender: jing@jing.rocks)
	by mail.jing.rocks (Postfix) with ESMTPSA id 2F8E234648;
	Fri,  7 Jun 2024 18:47:51 +0900 (JST)
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type
Date: Fri,  7 Jun 2024 18:43:23 +0900
Message-ID: <20240607094734.3883693-1-jing@jing.rocks>
X-Mailer: git-send-email 2.45.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DKIM_SIGNED               0.1 Message has a DKIM or DK signature, not necessarily valid
	DKIM_VALID               -0.1 Message has at least one valid DKIM or DK signature
	DKIM_VALID_AU            -0.1 Message has a valid DKIM or DK signature from author's domain
	DKIM_VALID_EF            -0.1 Message has a valid DKIM or DK signature from envelope-from domain
	DMARC_PASS               -0.1 DMARC pass policy
	KAM_INFOUSMEBIZ          0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware
	KAM_OTHER_BAD_TLD        0.75 Other untrustworthy TLDs
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
	T_SCC_BODY_TEXT_LINE    -0.01 -
	URIBL_BLOCKED           0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked.  See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jing.rocks]
X-Mailman-Approved-At: Fri, 07 Jun 2024 13:01:21 +0200

gcc warns (-Werror=type-limits) that it will always be false for the
if statement. This is because here s->aid is defined as char, while
proxmox_restore_open_image() returns an int. Change the type to int.
Strangely gcc warns it on arm64 build but not amd64 build...

Signed-off-by: Jing Luo <jing@jing.rocks>
---
 ...2-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
index b9578ba..9e68167 100644
--- a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
+++ b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
@@ -68,7 +68,7 @@ index 0000000000..dd72356bd3
 +
 +typedef struct {
 +    ProxmoxRestoreHandle *conn;
-+    char aid;
++    int aid;
 +    int64_t length;
 +
 +    char *repository;
-- 
2.45.2




--===============2646563350227714028==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

--===============2646563350227714028==--