From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1909E1FF183 for ; Wed, 27 Aug 2025 09:35:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2123912143; Wed, 27 Aug 2025 09:35:16 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Sat, 23 Aug 2025 10:17:05 +0200 In-Reply-To: <20250823083010.145866-1-aclopte@gmail.com> References: <20250823083010.145866-1-aclopte@gmail.com> X-Mailman-Approved-At: Wed, 27 Aug 2025 09:35:14 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Johannes Altmanninger via pve-devel Precedence: list Cc: Johannes Altmanninger X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH vncterm 1/4] Remove dead code and buffer-overflow Content-Type: multipart/mixed; boundary="===============5404966255448303387==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============5404966255448303387== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4BF1FD4893 for ; Sat, 23 Aug 2025 10:31:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F30B1CCC2 for ; Sat, 23 Aug 2025 10:31:01 +0200 (CEST) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 23 Aug 2025 10:30:59 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-afcb78ead12so393419766b.1 for ; Sat, 23 Aug 2025 01:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755937853; x=1756542653; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VNVUgM4ZrikJw7wjV022s05OI8WmtIDY0++ZpH9Jpn4=; b=KWqvVu+vkkxJtSd6suxOzag0zNUZtVRcHS+DJgvXbpVq2IRsZBDoMQw9Q0EucfyTc0 6TZU6yBmatsRxkSra9eiVkd0YVaZdS1dOiEwT7DgaN2fjMqm6iZ/iBqlYyDaELv+XsuT y/YwjiiyPffV5NRvyEeSS+uaDc4RtMg4DTy5hKjSVLb5FiCspXsqt2fu7MBj4p4uIBlW 9FpfHEkhNWPVOgZXQnYervNkXZtXIicHbjHTFqxufvnwN1kx5fespN1UI/MZBsj4YGEe D7DwD3ATKZQ2CLER/plBCBWt711aLvFccdFaBV4WPm5QYmggDnmikLrbZdtw0VznqOW3 eryg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755937853; x=1756542653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VNVUgM4ZrikJw7wjV022s05OI8WmtIDY0++ZpH9Jpn4=; b=m9AJbFEXeg3CmjongRmAITqoe8QT53vHPtsLycvAMk1CwnKzOcqjbm+pDaALYj8S8m ySE428eNQAYtx0cBCxmDMdvi0XQ2hFGmJx2QW5HqP1drVUuZUvFLVcD/YltTavNthIDK Bx2qTbqsmiJ7NHFQxdLPCofdzY30cWoK7EkKKknpeEGVdLyKNFRA8/F0DDCizS+3mtnR 8lYkRi7AnOJNgWTRtGAXFQ7nCBDZ/uf5A7mDdeyUiPjVT9CTGAsiXEitr5ruoL8UIZ1r LVb2bGF8F4dNmJJK9ZrqWVw3NCRqZLG1B89RGj1Qxg7BkY1RWIfRBfgp9rvtKSFZxze2 jKuQ== X-Gm-Message-State: AOJu0YyeB0vhKDPvoo1L4nP6ZFw+1UNk0pEnqVKxxhGEHaieELILsEIe 7yVCa+/Qy7LRIcL8crKPWv1OiUh9SSlf9s/o9JnpeAtuxjYft0UrKl3LDEoXMg== X-Gm-Gg: ASbGncvvPQJ7J8gcB7jdOg6nyILi0txYYaVbuQ63GxAXSsEyMO8CS9K8YR/EXcScjNf +JZTh0+uaOp3wnYyOMlZu4ayEVUlDcjsNRvnB+eUltS3E8rah9WtuU1CCihSAf1gAKwOyvQaHGp ra0Ikrz5k/rDu8IhIHYDhNXUCRHdAqi/YfmGwdQPRxdVjZZeahiE1WCaj6HZyBn3pEwjj7pixm4 uCPy7QI/FOtNisFOKBTL/f0bh86H7p2XYzvqnxehpGodDvwGNyPc1qwomJ4Ejuwwq01ZqnOz4Ls qvWAQAPixMoN+NwqyW35aljpuh3K0iegtDQOtC6TnOIBAcphXn+lPiH0zX/61r59mHUl+8bZJAg rfjWC7QHVJZppOky3MwXkKs+BXtmv X-Google-Smtp-Source: AGHT+IFQwKmwlDY5+W2RxsPbd6mOCZ8IH5EHH6mwCziB3kUAG4d5paFKXu2hhK5i7pj5T26D7du7Kw== X-Received: by 2002:a17:907:d10:b0:af9:618f:83e with SMTP id a640c23a62f3a-afe2904321bmr520492766b.37.1755937850253; Sat, 23 Aug 2025 01:30:50 -0700 (PDT) Received: from localhost.localdomain ([2001:4bc9:1fb6:b776::e07]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-afe48e85be7sm131312666b.13.2025.08.23.01.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Aug 2025 01:30:49 -0700 (PDT) From: Johannes Altmanninger To: pve-devel@lists.proxmox.com Cc: Johannes Altmanninger Subject: [PATCH vncterm 1/4] Remove dead code and buffer-overflow Date: Sat, 23 Aug 2025 10:17:05 +0200 Message-ID: <20250823083010.145866-2-aclopte@gmail.com> X-Mailer: git-send-email 2.50.1.194.g038143def7 In-Reply-To: <20250823083010.145866-1-aclopte@gmail.com> References: <20250823083010.145866-1-aclopte@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-Mailman-Approved-At: Wed, 27 Aug 2025 09:35:14 +0200 Signed-off-by: Johannes Altmanninger --- vncterm.c | 13 ++----------- vncterm.h | 2 -- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/vncterm.c b/vncterm.c index 3dd5d4e..fd71092 100644 --- a/vncterm.c +++ b/vncterm.c @@ -1276,8 +1276,6 @@ static void vncterm_putchar(vncTerm *vt, unicode ch) { case '1': case '2': case '4': - vt->osc_cmd = ch; - vt->osc_textbuf[0] = 0; vt->tty_state = ESosc1; break; default: @@ -1299,16 +1297,9 @@ static void vncterm_putchar(vncTerm *vt, unicode ch) { } break; case ESosc2: - if (ch != 0x9c && ch != 7) { - int i = 0; - while (vt->osc_textbuf[i]) { - i++; - } - vt->osc_textbuf[i++] = ch; - vt->osc_textbuf[i] = 0; - } else { + if (ch == 0x9c || ch != 7) { #ifdef DEBUG - fprintf(stderr, "OSC:%c:%s\n", vt->osc_cmd, vt->osc_textbuf); + fprintf(stderr, "OSC sequence\n"); #endif vt->tty_state = ESnormal; } diff --git a/vncterm.h b/vncterm.h index 7887d9b..82f9959 100644 --- a/vncterm.h +++ b/vncterm.h @@ -58,8 +58,6 @@ typedef struct vncTerm { unsigned int esc_count; unsigned int esc_ques; unsigned int esc_has_par; - char osc_textbuf[4096]; - char osc_cmd; unsigned int region_top; unsigned int region_bottom; -- 2.50.1.194.g038143def7 --===============5404966255448303387== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============5404966255448303387==--