From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A25711FF161 for ; Sat, 27 Sep 2025 13:13:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E3A8A1D34C; Sat, 27 Sep 2025 13:13:46 +0200 (CEST) Date: Sat, 27 Sep 2025 13:13:36 +0200 To: pve-devel@lists.proxmox.com References: <20250923174007.84121-1-proxmox8914@herold.me> <0c613244-24ea-4538-83b6-bc25e71a045d@proxmox.com> In-Reply-To: MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Constantin Herold via pve-devel Precedence: list Cc: Constantin Herold , Lukas Wagner , Thomas Lamprecht X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort Content-Type: multipart/mixed; boundary="===============7142503846121177693==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This is a multi-part message in MIME format. --===============7142503846121177693== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C633D65BD for ; Sat, 27 Sep 2025 13:13:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 761701D333 for ; Sat, 27 Sep 2025 13:13:45 +0200 (CEST) Received: from core.fw.herold.me (unknown [IPv6:2a06:de00:1337:beef::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 27 Sep 2025 13:13:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=herold.me; s=mail; t=1758971617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tDNRLeRiehqPXCp45F/BsV5hk3sH0TgkTZQRCUAgswk=; b=BjGDNvbWmu/1RQFwR9PHaM4Mj/ajhjYTDMP+uWDQ7M8uIXzL+WLZoY9svQFHrhmhWsVZel 7p9HZvQXjbjcaOp8ghS2kBCdFDRAxLwct0F3cGwdtTPhQJwXeV0RclDQbc38vov0iBM0Oe 1CXjx/hXQe4pDLSdutqsU4XShESGbRw/tjUip/97dsn2i+BnPypnUKN9euv29R6TTS6rhe NuZPcTRsiMEaRCI4awlu4itgWfe+BB2Z/8TpIM6gvSeVNRnhvnT+PoUR6kF4lTA/i6ZhDO c2vw2GAjb3z9Qntk9HrXzth/j9W7xygoab4B9AmkQ+UitOCoD5KhRD2zn+YIJw== Message-ID: <54300259-e13c-44c8-8382-872591d7bfcc@herold.me> Date: Sat, 27 Sep 2025 13:13:36 +0200 MIME-Version: 1.0 Subject: Re: [pve-devel] [PATCH pve-manager 0/1] feat: pass backup status to hook script on job-end/job-abort To: pve-devel@lists.proxmox.com References: <20250923174007.84121-1-proxmox8914@herold.me> <0c613244-24ea-4538-83b6-bc25e71a045d@proxmox.com> Content-Language: en-US Cc: Thomas Lamprecht , Lukas Wagner From: Constantin Herold In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy HTML_MESSAGE 0.001 HTML included in message KAM_INFOUSMEBIZ 0.75 Prevalent use of .info|.us|.me|.me.uk|.biz|xyz|id|rocks|life domains in spam/malware RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [herold.me,proxmox.com] Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 So I wanted to migrate to the notification system now, but since you can't limit webhooks by type e.g. `backup result` it's not possible without another custom middleware service which would add unnecessary maintenance overhead and an additional point of failure. On 24.09.25 18:48, Constantin Herold via pve-devel wrote: > > Re: [PATCH pve-manager 0/1] feat: pass backup status to hook script.eml > > Subject: > Re: [PATCH pve-manager 0/1] feat: pass backup status to hook script on > job-end/job-abort > From: > Constantin Herold > Date: > 24.09.25, 18:48 > > To: > Thomas Lamprecht , pve-devel@lists.proxmox.com > CC: > Lukas Wagner > > > Thanks Thomas, I wasn't aware of the builtin webhook support, seems > like I can do what I need with the builtin `handlebars` templating > engine. > > I still think my patch would be a great addition given that scripting > capabilities are not limited in any way. > > Let me know if I need to do anything else for the Proxmox Team to > review it. > > > On 24.09.25 11:40, Thomas Lamprecht wrote: >> FWIW, for this the notification system might be better suited, it >> already >> has support for various targets, including web hooks. That doesn't mean >> adding info to the hook is not needed, just wanted to mention that it >> exist >> and that one option might be to provide support for trigger a dedicated >> notification for each single backup "sub-job", which would avoid the >> need >> for having a custom hook if it's just to get a dedicated notification >> / hook >> ASAP for each failed backup of a guest (vs. the overall result of the >> backups >> of all guests). >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7142503846121177693== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7142503846121177693==--