From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 59B501FF191 for ; Tue, 23 Sep 2025 05:22:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9DCF323BC; Tue, 23 Sep 2025 05:22:37 +0200 (CEST) To: "Max R. Carrara" , Proxmox VE development discussion Date: Tue, 23 Sep 2025 03:06:56 +0000 References: In-Reply-To: MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Lorne Guse via pve-devel Precedence: list Cc: Lorne Guse X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] busy dataset when trying the migrate iscsi disk Content-Type: multipart/mixed; boundary="===============7429247956773527488==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============7429247956773527488== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 85DB6D418B for ; Tue, 23 Sep 2025 05:22:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F8402387 for ; Tue, 23 Sep 2025 05:22:05 +0200 (CEST) Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azolkn190100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:d109::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 23 Sep 2025 05:22:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f7HFrTLOnQax93NhYkzzeKye2mnpEN8wB6FT6VGzON7pk+FttFECS1N7eyNFYLgIm89FnoFBse49gfsRf5wJI5krkL6KjXpgDan6HZsljwPJuAB/0FpFy73sjCgvaNYghXFIIEBpCELLQxFtFaErBYXSBUIPaoNYFms6afdCDUXRS5k2cfBDyNJ3z5QhVvzGtD8PghdfxiBYh06Znl4BlAfNsrNWjyX+6KaTKHFjdT6CxNn0iGAzcGgfmUdVLQTd2oP8VCCVTWkuWx9y6ypiV1vE6m+MCB580NheC0WS8MXq0V+a3+blEAeKmoJirD3g5Hd/We/qftADk7MmeePCjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wcxK+V5T0Tw/xM5LIKa3BkhsO0XmcZEW5BIigBklf0=; b=ulq/I6Uw9eosqs7W4N7OWCMTcrrt7Wac/Vv+hSPW5AWL0sidhckY4v13h0Zk3f35FemzfXUVgjzNe4hzWbmbG47fM6hn+ktSLnv+cP7Tr0oJ7iVfzOhnnhUAYpSJghuPeZWU1La38Lf2yXx7894ERiGlgy0x0Xxs83g8NI7vIGFmLBmi1Ox0TrnhGNJ1gibboV75Td3ssMtyY2/JmWWhX3jrtu6nymf9Zy7p0jYPoyqqmJ1XGFgmm//iyvQG00xODFPmHlm5WzAFGaZTIiSvCrm80ddWQ6ndf16Gi2557BtDQhNFYzNinq3j9c3tIrlh/M2XZsvn6vcFdW/szCckFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wcxK+V5T0Tw/xM5LIKa3BkhsO0XmcZEW5BIigBklf0=; b=jbZGvBJBXiGSFV/rDo4tZF6IgDjd3LlQCSfSwq3odtFSHvRoF9YD5k6gefkiBxrSTqkpUiP4TRaDUbezXfC3SX47ufXOydPVGuD/MEH4OtndaAP4PQY9ktAAz4W2IvC8Vuj+z4lMzdirY2KckPoZ5Q8fuIZNbFJmnsMhXMBPVObg/6Ls5GaZhO3aNqkPS5AxZWbCvhNron/zUsW2yTItTcG9QhBGYNt+R7bEozTGIxUMGtbT4S/TtdF1asJRLbCMmt0CN90UO2UXx9dnbG9vJZOMgI0T85SqwgQWkUxft7fXZjP4a0bbCNVFgWKYSKzdvayOqneOkWnxcva/W2jN6w== Received: from DM6PR17MB3466.namprd17.prod.outlook.com (2603:10b6:5:1df::23) by SJ0PR17MB5933.namprd17.prod.outlook.com (2603:10b6:a03:437::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9137.16; Tue, 23 Sep 2025 03:06:56 +0000 Received: from DM6PR17MB3466.namprd17.prod.outlook.com ([fe80::e9a8:2d84:b202:de5c]) by DM6PR17MB3466.namprd17.prod.outlook.com ([fe80::e9a8:2d84:b202:de5c%6]) with mapi id 15.20.9137.018; Tue, 23 Sep 2025 03:06:56 +0000 From: Lorne Guse To: "Max R. Carrara" , Proxmox VE development discussion Subject: Re: busy dataset when trying the migrate iscsi disk Thread-Topic: busy dataset when trying the migrate iscsi disk Thread-Index: AQHcJfFQa4et/y9I0Uq+NSt187RQxrSXSocAgAjUXtM= Date: Tue, 23 Sep 2025 03:06:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, en-CA Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR17MB3466:EE_|SJ0PR17MB5933:EE_ x-ms-office365-filtering-correlation-id: 78b6a82d-09ea-40de-9470-08ddfa4e4144 x-microsoft-antispam: BCL:0;ARA:14566002|461199028|15080799012|12050799012|15030799006|9000799056|31061999003|8062599012|8060799015|9400799037|19110799012|1680799063|1602099012|40105399003|440099028|4302099013|3412199025|10035399007|102099032|12091999003; x-microsoft-antispam-message-info: =?us-ascii?Q?tIk0RTR9uvjWVY01jmrbBVdpKslf12yZAoRYePsqM/WhsOYgTmPJtqC9DSj7?= =?us-ascii?Q?gJLISk1t4vXV6VIIKOiCKdoO9T1BLtKFjWNyOaPla++huvpZzI1rpeAvHaY3?= =?us-ascii?Q?0gYflEAWmc8nXWp1K7K5BSi2E5VgGGCwfvA/OGgNQCLaWyPsO0YUuX86Va/M?= =?us-ascii?Q?JnRwIfjwMmbhlzOGVlL+Mjg81YKo5G3cOldFRn+Q3yORkic7UdHx7VEXFYTu?= =?us-ascii?Q?GSNvxT9ZiH4td2J3n1MjDElhjY0zl918swPj1WCgWNDS4SSxZZWuGH7ldKpt?= =?us-ascii?Q?Y9DmwUeBlPZ88Ne/KeNAnsN1vXcynSOmPNy61d/xOptqmzUMkrj9i5pUtcAj?= =?us-ascii?Q?zYI/+xluf7SW33k4JDvzGZEo9hNwz0p+HYK9fHjiGOHlavX2Io3e+k0cXuaP?= =?us-ascii?Q?6OJacNVg+9aLL8AvYsRW9q6FqkuKdczScu6lNBBnADDlT/yBA7EnVj/wPP0m?= =?us-ascii?Q?t7i70Bzb2PWuw7k8ucKZap1no7EGXC+OnmQ75am+etgsBoCVxuYdDxdUfED4?= =?us-ascii?Q?3mqvy2DoeynaBE1bch9FYKkZD60zZ8lXptFR7rriqoxphOtqpKyjw5kKzlIG?= =?us-ascii?Q?v2hu9tvaElJ+sWiZbY+EO4c8Q04Qex7OyRYDQhOCSMOkMZ0Va4fDtxkvYiz9?= =?us-ascii?Q?6haUruwPyeW9YR7kJGAygtviktC2f6zvdJoSrQxJUtvbe0q/okDvyoEBo6Un?= =?us-ascii?Q?lkYTylBROX23VN0mGSXCOTk1pdoCE71Hig4qZ8F/vb9XuMT9gVFdWC2sdl+Y?= =?us-ascii?Q?0xcx7q+O6tkuvlT06tkOfNZVzWQJEv5cDr2gKfW/nJCOOajOlmsHwXwT1wa0?= =?us-ascii?Q?ZGlmKuxuPm8v73BtN6+/QOPDtsfGfD4Z4ssfWDymD8VcadWJhE0GWXI6GR9H?= =?us-ascii?Q?i//UK5foJtJd7e4IUs1/9iFDn6tc7G3RjJD0KUSJHMRgXf2H/JKZFbZJCvz8?= =?us-ascii?Q?OHL3GwUps+ijwOUz4kXkpjUe5uArjUn92CxJsGJ9Vl7bOZVRLZUR93Hjs9AZ?= =?us-ascii?Q?CLWnUtL1Spym1Xg+f89NQwGz7hPny8zuEU1sdkE3IMNFjDwGYCdxt76j5mkJ?= =?us-ascii?Q?ql/gLxu1dSQ75OxXVuaXrUDYUigRXQt6uVehCAJsyFxagA7IdABHVefRtxx9?= =?us-ascii?Q?S69FIWlfKN9DlG4rCI8W0ic9CgpqtY+NmqV1VKqtXRPMlLgb+htCdNhpPZ6P?= =?us-ascii?Q?UcKArMzf78pPYZCpBdlq4ak8K3XO45iWqXcFF9oKbXNokIYPl5dCvYANizzx?= =?us-ascii?Q?z0rp4Kvw6rlB/rGxtKAx8W8ohvoCs5Hr0NNBknFCqTG6nzzGrb2M6KFRp9fi?= =?us-ascii?Q?CVk7FlQSn3lASIfLK07C8XVyl2VuySmh20iKuNsLSAJEHYMmP4c6FDWwLpDo?= =?us-ascii?Q?hH0nYNsaOuTURhQiGxmvotShGwnw/yBd+k5UIKujlZXnzd7djQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xB4HaV/7EOKSgEECqw0k0B4DpN7IHcRf/189HX2hjoaZMOBoQ/vs+MnrRs4t?= =?us-ascii?Q?IbXMMeUl5xOkiLS86q8rhYIfPt60JGo0LSqlPIQgTkL/iPG716gKfYIkY7n7?= =?us-ascii?Q?OAJ7P6xjmJK+qtzJW1OeFqbHrXTlwC3LwUEUnDuzLLsQEXQueG96BY6sjAfz?= =?us-ascii?Q?9m1xvRSGBWHaGkSRdbFpK6+r646qUp0yvnDyLAydSZolskuEJaqYnEI0UF67?= =?us-ascii?Q?RNzMVZ9PJb3NcoV5aIuGfu/vIn89WbK7nj+Xs7foJAts4/v/YiDGiOtA2AkJ?= =?us-ascii?Q?TSn03M46eN6debDDq04LtrQ8FMjJSKoTtUHpi8BcySyNnckucCg1vUp9BoSS?= =?us-ascii?Q?l+IjqLb8ru4xtNq11jRBRvXDIzgwsOAsYaL3lPTquKju7WlF3LKJHwDvsleF?= =?us-ascii?Q?trnyeBTyBPxKSSHUU7SpbZ8scAADUTeojr5m8bS4R9V28LoDADpslh53byFr?= =?us-ascii?Q?hCDzI3USVDN5CEC+re0cYvRwqoPFs6ZMjRp/es19Auc+xOcPCqt1Zp5RNnej?= =?us-ascii?Q?7bH45GeG0wmOLfArQ0uPatHLqzv5VbhJWhsjR28QH9OnOV93tTtZjD38cXUl?= =?us-ascii?Q?pCVKlLE1/6H+4c85pTOVIOdIATHE1fpiOHmQuqzx7XQd9X3yxmh08ZiTlzNX?= =?us-ascii?Q?bDJCHCPeLETX4O9qPwr3FQSj70aSnW35S6Yu7h2JGwXGC7LeGnUuyzdnGtXQ?= =?us-ascii?Q?LZ0lvTC0qvHuLMUm5h6np8v5vBqjg+yeEOYo3GWR2pkBHUnOQUlCl6KFEQ8r?= =?us-ascii?Q?j7S1npTHLyQ8WWY7C379I+MYjrbo/czYADeQ/tOpicUyMeL+vNqhgddVpZVK?= =?us-ascii?Q?/nE20fOB2+1K92WVzwdsiH4jaAd6jNQSxzLHstAuLmS7O8elQ/lvEkwdH84B?= =?us-ascii?Q?vkIalULoox+NY79Y5SsmKo94/vHrn39koMZFL3IdI/bVdpf1MnmCfhmTlioi?= =?us-ascii?Q?fKNRdSNLX8lmv/cJA0wK/kgJrGvJAVOm0gvG52fWMFqbILjtrTw/jT5a4b7l?= =?us-ascii?Q?k/laZKjx7x+qaXuA9/SWiypTQdBd89MTolvgu8Eixyb8WC+ibMrxyHD8bOPz?= =?us-ascii?Q?SA3xDoIiVo1rRo1ll0oSexcN2dvTH+I41PmwSRQeQEl4SlqELimrma8sLbiG?= =?us-ascii?Q?fG95RFdfs9z79QIbDcCRxB6bKs/wFVVIyB/5sEZTo0U/9uQRZ6MSNLqWLl//?= =?us-ascii?Q?MkJJiDef34oSWn01ziayoD7yHpAsM+dnwJ+N3ZpEXi7HldJOhPS2i9Db6yY?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-31e5f.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3466.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 78b6a82d-09ea-40de-9470-08ddfa4e4144 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2025 03:06:56.5767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB5933 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature AWL -0.367 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider GB_GEN_REDIR_URL 0.5 Redirector found in href link HTML_MESSAGE 0.001 HTML included in message HTTPS_HTTP_MISMATCH 0.1 - KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record T_REMOTE_IMAGE 0.01 Message contains an external image URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,zfspoolplugin.pm,githubassets.com] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 I had a look at the code in ZFSPoolPlugin.pm and found why we are having an= issue deleting the zvol https://github.com/boomshankerx/proxmox-truenas/issues/52#issuecomment-3322= 144855 This code doesn't seem to match the error message we are getting when delet= ing the zvol: cannot destroy 'slow/vm-188-disk-0': dataset is busy sub zfs_delete_zvol { ... if ($err =3D~ m/^zfs error:(.*): dataset is busy.*/) { ... } If this code was simplified to match 'dataset is busy' it would work. This issue won't exist in my new custom plugin since I override free_image.= It is causing issues for the old patch version users. I don't really want = to go and patch ZFSPoolPlugin.pm since the new plugin is right around the c= orner. I told the users having the issue that I would make an attempt to resolve i= t. Otherwise they have to wait for and upgrade to TrueNAS 25.10 and the ne= w plugin. [https://opengraph.githubassets.com/9e61db5ee7ae1557d66bf3cc5dc92f5ae80c4b3= 3a981241e95afc86f146d8626/boomshankerx/proxmox-truenas/issues/52] Issue with Deleting data sets using the new storage plugin Not sure if this is an issue with my nas instance or not. It complains the = data sets are busy when I go to delete them causing it fail, and then fail = to re add them back as an extent root@guardian:... github.com ________________________________ From: Max R. Carrara Sent: Wednesday, September 17, 2025 6:04 AM To: Lorne Guse ; Proxmox VE development discussio= n Subject: Re: busy dataset when trying the migrate iscsi disk On Mon Sep 15, 2025 at 5:34 AM CEST, Lorne Guse wrote: > I'm working on TrueNAS over iSCSI for Proxmox and have run into an issue = migrating disks. When trying to delete the old storage, which has just succ= essfully been transfered, the iscsidirect connection must remain open becau= se we are getting: > > cannot destroy 'slow/vm-188-disk-0': dataset is busy > > Is there a way to ensure the iscsidirect connection is closed before tryi= ng to delete the underlying zfs dataset? Hi Lorne! Glad to see you on the mailing list! I've sifted around our code to see how we handle this, and it seems that we're simply retrying a couple of times until the dataset is actually deleted [0]. I think that might be your best bet, though if you find an alternative, I'd be curious to know. [0]: https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= .proxmox.com%2F%3Fp%3Dpve-storage.git%3Ba%3Dblob%3Bf%3Dsrc%2FPVE%2FStorage%= 2FZFSPoolPlugin.pm%3Bh%3Dd8d8d0f9fc1cc6f1a02d8f5800c388b355609bf5%3Bhb%3Dre= fs%2Fheads%2Fmaster%23l362&data=3D05%7C02%7C%7C08ddb2ac62744e0c4a2908ddf5e2= 59ac%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638937074705932603%7CUnkn= own%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zM= iIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=3DdV3Ch024RrnvSKKDsT= 4k1zP23S%2BCX9jFR6YISZ5Lpe0%3D&reserved=3D0 --===============7429247956773527488== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7429247956773527488==--