From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 875751FF17C for ; Wed, 3 Sep 2025 18:07:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F6E112673; Wed, 3 Sep 2025 18:07:44 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Tue, 2 Sep 2025 20:20:30 +0200 In-Reply-To: <20250902182031.1080266-1-bugzilla.proxmox.com@lookshe.org> References: <20250902182031.1080266-1-bugzilla.proxmox.com@lookshe.org> X-Mailman-Approved-At: Wed, 03 Sep 2025 18:07:41 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Sebastian Luksch via pve-devel Precedence: list Cc: Sebastian Luksch X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH manager 1/1] use Term::ReadLine->new() only once Content-Type: multipart/mixed; boundary="===============7133702698458067952==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============7133702698458067952== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57C50D2AA7 for ; Tue, 2 Sep 2025 20:21:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 410361A35C for ; Tue, 2 Sep 2025 20:21:50 +0200 (CEST) Received: from ispc.huaraka.de (ispc.huaraka.de [IPv6:2a01:4f8:231:96::1:102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 2 Sep 2025 20:21:49 +0200 (CEST) Received: from ispc.huaraka.de (localhost [127.0.0.1]) by ispc.huaraka.de (Postfix) with ESMTP id D1AA81988AD6 for ; Tue, 2 Sep 2025 20:20:53 +0200 (CEST) Received: from localhost.localdomain (unknown [10.0.0.107]) by ispc.huaraka.de (Postfix) with ESMTP id 93B9E1988AD8; Tue, 2 Sep 2025 20:20:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lookshe.org; s=default; t=1756837233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fgoaxk2k/N2nH3aQuIOYxVQComWqDjG8/7TCOUn30DI=; b=JB9cL7gbmw+Dg2zjUg5CozCVhj4yQMnbHd9/OS+U5vHhmRo+8gsWNRhXozaAGc4UrYzGxv adOGyY4sd2isA+IRKN6/Zw4a0mRNSOU6JrcPZL5GVfLMd1F+fUwKksWTjPQp16rc2rLUgx WwvuwOX1IBPBZtmCFThqxZS75leLJRCyQ8Ki7nCSKkANEY4wzcMhJ3QgJwNL/PClC+bYpO QvZ42EhjHryulJGpBomVJBbiUrxvjgrNhENMdXtbU9vQNU2u66O08o439j2DrNLRfRXbya Nzf94a3tlIexmXOFHKD7a5iRiBCB+Xw7PQLnyahEycxxKewX41y8gK3mQPM6hA== Authentication-Results: ispc.huaraka.de; none From: Sebastian Luksch To: pve-devel@lists.proxmox.com Cc: Sebastian Luksch Subject: [PATCH manager 1/1] use Term::ReadLine->new() only once Date: Tue, 2 Sep 2025 20:20:30 +0200 Message-Id: <20250902182031.1080266-2-bugzilla.proxmox.com@lookshe.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20250902182031.1080266-1-bugzilla.proxmox.com@lookshe.org> References: <20250902182031.1080266-1-bugzilla.proxmox.com@lookshe.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-0.10 / 100.00]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[lookshe.org:s=default]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; IP_WHITELIST(0.00)[ip=10.0.0.107]; FROM_HAS_DN(0.00)[] X-Rspamd-Action: no action X-Rspamd-Pre-Result: action=no action; module=multimap; Matched map: IP_WHITELIST X-Rspamd-Server: ispc X-Rspamd-Queue-Id: 93B9E1988AD8 X-Spam-Status: No, score=-0.10 X-Spamd-Bar: / X-SPAM-LEVEL: Spam detection results: 0 AWL 1.250 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record X-Mailman-Approved-At: Wed, 03 Sep 2025 18:07:41 +0200 --- PVE/CLI/pvenode.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/PVE/CLI/pvenode.pm b/PVE/CLI/pvenode.pm index 76b05887..466170f4 100644 --- a/PVE/CLI/pvenode.pm +++ b/PVE/CLI/pvenode.pm @@ -97,6 +97,7 @@ __PACKAGE__->register_method({ my ($param) = @_; my $custom_directory = 0; + my $term = Term::ReadLine->new('pvenode'); if (!$param->{directory}) { my $directories = PVE::API2::ACMEAccount->get_directories({}); print "Directory endpoints:\n"; @@ -108,7 +109,6 @@ __PACKAGE__->register_method({ } print $i, ") Custom\n"; - my $term = Term::ReadLine->new('pvenode'); my $get_dir_selection = sub { my $selection = $term->readline("Enter selection: "); if ($selection =~ /^(\d+)$/) { @@ -137,7 +137,6 @@ __PACKAGE__->register_method({ if ($meta->{termsOfService}) { my $tos = $meta->{termsOfService}; print "Terms of Service: $tos\n"; - my $term = Term::ReadLine->new('pvenode'); my $agreed = $term->readline('Do you agree to the above terms? [y|N]: '); die "Cannot continue without agreeing to ToS, aborting.\n" if ($agreed !~ /^y$/i); @@ -149,7 +148,6 @@ __PACKAGE__->register_method({ my $eab_enabled = $meta->{externalAccountRequired}; if (!$eab_enabled && $custom_directory) { - my $term = Term::ReadLine->new('pvenode'); my $agreed = $term->readline('Do you want to use external account binding? [y|N]: '); $eab_enabled = ($agreed =~ /^y$/i); @@ -158,7 +156,6 @@ __PACKAGE__->register_method({ } if ($eab_enabled) { print "You should have received a key id and a key from your CA.\n"; - my $term = Term::ReadLine->new('pvenode'); my $eab_kid = $term->readline('Enter EAB key id: '); my $eab_hmac_key = $term->readline('Enter EAB key: '); -- 2.30.2 --===============7133702698458067952== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7133702698458067952==--