From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9CD691FF183 for ; Wed, 16 Jul 2025 08:32:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C983015E87; Wed, 16 Jul 2025 08:32:37 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Wed, 16 Jul 2025 08:31:53 +0200 In-Reply-To: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com> References: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH FOLLOW-UP storage 14/14] storage: remove $running param from volume_snapshot Content-Type: multipart/mixed; boundary="===============8416242019878431495==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============8416242019878431495== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E404DACCB for ; Wed, 16 Jul 2025 08:32:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3310C15D06 for ; Wed, 16 Jul 2025 08:32:11 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [185.151.190.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Jul 2025 08:32:06 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 67D8D862E5F; Wed, 16 Jul 2025 08:31:56 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 65763104D614; Wed, 16 Jul 2025 08:31:56 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH FOLLOW-UP storage 14/14] storage: remove $running param from volume_snapshot Date: Wed, 16 Jul 2025 08:31:53 +0200 Message-Id: <20250716063153.1647681-19-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com> References: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -1.416 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] not needed anymore after change in qemu-server Signed-off-by: Alexandre Derumier --- ApiChangeLog | 4 ---- src/PVE/Storage.pm | 4 ++-- src/PVE/Storage/ESXiPlugin.pm | 2 +- src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +- src/PVE/Storage/LVMPlugin.pm | 11 +---------- src/PVE/Storage/LvmThinPlugin.pm | 2 +- src/PVE/Storage/PBSPlugin.pm | 2 +- src/PVE/Storage/Plugin.pm | 16 ++++++---------- src/PVE/Storage/RBDPlugin.pm | 2 +- src/PVE/Storage/ZFSPoolPlugin.pm | 2 +- 10 files changed, 15 insertions(+), 32 deletions(-) diff --git a/ApiChangeLog b/ApiChangeLog index 68e94fd..58996a9 100644 --- a/ApiChangeLog +++ b/ApiChangeLog @@ -22,10 +22,6 @@ Future changes should be documented in here. Feel free to request allowing more drivers or options on the pve-devel mailing list based on your needs. -* Add `running` parameter to `volume_snapshot()` - The parameter *can* be used if some extra actions need to be done at the storage - layer when the snapshot has already be done at qemu level when the vm is running. - * Introduce rename_snapshot() plugin method This method allow to rename a vm disk snapshot name to a different snapshot name. diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm index b3ca094..893b611 100755 --- a/src/PVE/Storage.pm +++ b/src/PVE/Storage.pm @@ -449,13 +449,13 @@ sub volume_rollback_is_possible { } sub volume_snapshot { - my ($cfg, $volid, $snap, $running) = @_; + my ($cfg, $volid, $snap) = @_; my ($storeid, $volname) = parse_volume_id($volid, 1); if ($storeid) { my $scfg = storage_config($cfg, $storeid); my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); - return $plugin->volume_snapshot($scfg, $storeid, $volname, $snap, $running); + return $plugin->volume_snapshot($scfg, $storeid, $volname, $snap); } elsif ($volid =~ m|^(/.+)$| && -e $volid) { die "snapshot file/device '$volid' is not possible\n"; } else { diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm index 66ef289..eeb6a48 100644 --- a/src/PVE/Storage/ESXiPlugin.pm +++ b/src/PVE/Storage/ESXiPlugin.pm @@ -561,7 +561,7 @@ sub volume_size_info { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; die "creating snapshots is not supported for $class\n"; } diff --git a/src/PVE/Storage/ISCSIDirectPlugin.pm b/src/PVE/Storage/ISCSIDirectPlugin.pm index 93cfd3c..62e9026 100644 --- a/src/PVE/Storage/ISCSIDirectPlugin.pm +++ b/src/PVE/Storage/ISCSIDirectPlugin.pm @@ -232,7 +232,7 @@ sub volume_resize { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; die "volume snapshot is not possible on iscsi device\n"; } diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 1f5a5f1..35e1732 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -959,21 +959,12 @@ sub volume_size_info { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; my ($vmid, $format) = ($class->parse_volname($volname))[2, 6]; die "can't snapshot '$format' volume\n" if $format ne 'qcow2'; - if ($running) { - #rename with blockdev-reopen is done at qemu level when running - eval { alloc_snap_image($class, $storeid, $scfg, $volname, $snap) }; - if ($@) { - die "can't allocate new volume $volname: $@\n"; - } - return; - } - $class->activate_volume($storeid, $scfg, $volname); #rename current volume to snap volume diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm index 13c0275..6f8a92e 100644 --- a/src/PVE/Storage/LvmThinPlugin.pm +++ b/src/PVE/Storage/LvmThinPlugin.pm @@ -353,7 +353,7 @@ sub create_base { # sub volume_resize {} reuse code from parent class sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; my $vg = $scfg->{vgname}; my $snapvol = "snap_${volname}_$snap"; diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm index 45edc46..00170f5 100644 --- a/src/PVE/Storage/PBSPlugin.pm +++ b/src/PVE/Storage/PBSPlugin.pm @@ -966,7 +966,7 @@ sub volume_resize { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; die "volume snapshot is not possible on pbs device"; } diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 439e4c3..2e16c59 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1272,7 +1272,7 @@ sub volume_resize { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; if ($scfg->{'external-snapshots'}) { @@ -1280,18 +1280,14 @@ sub volume_snapshot { my $vmid = ($class->parse_volname($volname))[2]; - if (!$running) { - #rename volume unless qemu has already done it for us - $class->rename_snapshot($scfg, $storeid, $volname, 'current', $snap); - } + #rename volume unless qemu has already done it for us + $class->rename_snapshot($scfg, $storeid, $volname, 'current', $snap); + eval { alloc_backed_image($class, $storeid, $scfg, $volname, $snap) }; if ($@) { warn "$@ \n"; - #if running, the revert is done by qemu with blockdev-reopen - if (!$running) { - eval { $class->rename_snapshot($scfg, $storeid, $volname, $snap, 'current'); }; - warn $@ if $@; - } + eval { $class->rename_snapshot($scfg, $storeid, $volname, $snap, 'current'); }; + warn $@ if $@; die "can't allocate new volume $volname with $snap backing image\n"; } diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm index 45f8a7f..541752e 100644 --- a/src/PVE/Storage/RBDPlugin.pm +++ b/src/PVE/Storage/RBDPlugin.pm @@ -866,7 +866,7 @@ sub volume_resize { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; my ($vtype, $name, $vmid) = $class->parse_volname($volname); diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index 28d4795..cdf5868 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -480,7 +480,7 @@ sub volume_size_info { } sub volume_snapshot { - my ($class, $scfg, $storeid, $volname, $snap, $running) = @_; + my ($class, $scfg, $storeid, $volname, $snap) = @_; my $vname = ($class->parse_volname($volname))[1]; -- 2.39.5 --===============8416242019878431495== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============8416242019878431495==--