From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 068BB1FF183 for ; Wed, 16 Jul 2025 08:31:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F640159F7; Wed, 16 Jul 2025 08:32:08 +0200 (CEST) To: pve-devel@lists.proxmox.com Date: Wed, 16 Jul 2025 08:31:35 +0200 MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Alexandre Derumier via pve-devel Precedence: list Cc: Alexandre Derumier X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: [pve-devel] [PATCH FOLLOW-UP storage/qemu-server] external qcow2 snapshot support Content-Type: multipart/mixed; boundary="===============4666374425819508487==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============4666374425819508487== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C3C94DAC9C for ; Wed, 16 Jul 2025 08:32:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69825157A3 for ; Wed, 16 Jul 2025 08:32:05 +0200 (CEST) Received: from bastiontest.odiso.net (unknown [IPv6:2a0a:1580:2000:6700::14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Jul 2025 08:32:03 +0200 (CEST) Received: from formationkvm1.odiso.net (unknown [10.11.201.57]) by bastiontest.odiso.net (Postfix) with ESMTP id 202EE860F13; Wed, 16 Jul 2025 08:31:56 +0200 (CEST) Received: by formationkvm1.odiso.net (Postfix, from userid 0) id 0E987104D614; Wed, 16 Jul 2025 08:31:56 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Subject: [PATCH FOLLOW-UP storage/qemu-server] external qcow2 snapshot support Date: Wed, 16 Jul 2025 08:31:35 +0200 Message-Id: <20250716063153.1647681-1-alexandre.derumier@groupe-cyllene.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -1.397 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_NONE 0.1 DMARC none policy HEADER_FROM_DIFFERENT_DOMAINS 0.001 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_NONE 0.25 DKIM has Failed or SPF has failed on the message and the domain has no DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] follow-up patch serie v8 https://lore.proxmox.com/all/39a3339c-d22b-4ec1-b16a-61e5eb91fd53@proxmox.com/T/ Fix Fabian && Wolfgang requests Major change is the removal $running for volume_snapshot (Thanks Wolgang for the ideas!) Still need to rework volume_support_qemu_snapshot, I'll not have time to do it before holiday, so if somebody can help on this, it could be great :) pve-storage: Alexandre Derumier (11): lvm snapshot: activate volume common: fix qemu_img_resize plugin: volume_export: don't allow export of external snapshots lvmplugin: alloc_snap_image: die if file_size_info return empty size lvmplugin: snapshot: use relative path for backing image plugin|lvmplugin: don't allow volume rename if external snapshots exist. lvmplugin: add volume_snapshot_info plugin: lvmplugin: add parse_snap_name plugin : improve parse_namedir warning lvmplugin: add external-snapshots option && forbid creation of qcow2 volumes without it storage: remove $running param from volume_snapshot Fabian Grünbichler (3): helpers: make qemu_img* storage config independent helpers: move qemu_img* to Common module rename_snapshot: fix parameter checks ApiChangeLog | 4 - src/PVE/Storage.pm | 7 +- src/PVE/Storage/Common.pm | 147 ++++++++++++++-- src/PVE/Storage/ESXiPlugin.pm | 2 +- src/PVE/Storage/ISCSIDirectPlugin.pm | 2 +- src/PVE/Storage/LVMPlugin.pm | 115 +++++++++---- src/PVE/Storage/LvmThinPlugin.pm | 2 +- src/PVE/Storage/PBSPlugin.pm | 2 +- src/PVE/Storage/Plugin.pm | 239 ++++++++------------------- src/PVE/Storage/RBDPlugin.pm | 2 +- src/PVE/Storage/ZFSPoolPlugin.pm | 2 +- 11 files changed, 295 insertions(+), 229 deletions(-) qemu-server: Alexandre Derumier (4): api2: move_disk: use parse_volname to find old volume format blockdev_rename: remove old left-over rename() generate_backing_blockdev: use current_sub for private recursive blockdev_external_snapshot: rework to avoid $running param src/PVE/API2/Qemu.pm | 5 +---- src/PVE/QemuServer.pm | 38 ++++++---------------------------- src/PVE/QemuServer/Blockdev.pm | 35 ++++++++++++++++++------------- 3 files changed, 28 insertions(+), 50 deletions(-) -- 2.39.5 --===============4666374425819508487== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============4666374425819508487==--