From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A0DC91FF187 for ; Mon, 14 Jul 2025 17:11:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 572331A3D5; Mon, 14 Jul 2025 17:12:46 +0200 (CEST) Date: Mon, 14 Jul 2025 16:12:04 +0100 To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <573493064.5243.1752160423097@webmail.proxmox.com> In-Reply-To: <573493064.5243.1752160423097@webmail.proxmox.com> MIME-Version: 1.0 Message-ID: List-Id: Proxmox VE development discussion List-Post: From: Tiago Sousa via pve-devel Precedence: list Cc: Tiago Sousa , Wolfgang Bumiller , Thomas Lamprecht X-Mailman-Version: 2.1.29 X-BeenThere: pve-devel@lists.proxmox.com List-Subscribe: , List-Unsubscribe: , List-Archive: Reply-To: Proxmox VE development discussion List-Help: Subject: Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support Content-Type: multipart/mixed; boundary="===============7302211058020382519==" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" --===============7302211058020382519== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: pve-devel@lists.proxmox.com Delivered-To: pve-devel@lists.proxmox.com Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56669D9560 for ; Mon, 14 Jul 2025 17:12:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E3561A36B for ; Mon, 14 Jul 2025 17:12:14 +0200 (CEST) Received: from eurotux.com (mail.eurotux.com [185.98.249.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 14 Jul 2025 17:12:12 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by eurotux.com (Postfix) with ESMTP id C703D30508B9; Mon, 14 Jul 2025 16:12:05 +0100 (WEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eurotux.com; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id; s=default; t= 1752505925; x=1754320326; bh=rNikdBdmOQPyjldAHmZJLRfA26SxlTD97j1 /i+oXdiw=; b=2mG4XWVn0tsTxgs6vrTjeZ9O+Ao+JnuJHc8I1s1zShXaeU5hVSV XMP3Nk1po0s6vXGNiIR7fZs8pD3bCTgwP/b3EqBqPSQ7q2tXcEvOMyWMiXSIfo8u pvWDulfEwthCH453OCD87Jw/YAo6KuZRlvkJaMUVLaXZzVDvIXtkVgG+Znnct6mY Wh0ecslSyMbu+Jm4ugOfkEjTMJfuKyDKHQ07Gq2ETST9fmURIc4tF5+N4wbjyOGE KW17u9uebjNEbDoCGNU3jEUavGaiPvl0JtW/F38ZtXekORJoxTsYXtE30pUMdH+K 9voDiui2D8hoaLDPpTrgdV51lJKgCeURsvQ== X-Virus-Scanned: amavisd-new at mail.prd.eurotux.pt Received: from eurotux.com ([127.0.0.1]) by localhost (mail.prd.eurotux.pt [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id iM-y9KE-vC6u; Mon, 14 Jul 2025 16:12:05 +0100 (WEST) Received: from [192.168.1.213] (unknown [161.230.225.89]) (Authenticated sender: joao.sousa@eurotux.com) by eurotux.com (Postfix) with ESMTPSA id 2F57A30C6F8E; Mon, 14 Jul 2025 16:12:05 +0100 (WEST) Message-ID: Date: Mon, 14 Jul 2025 16:12:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= Cc: Wolfgang Bumiller , Thomas Lamprecht References: <573493064.5243.1752160423097@webmail.proxmox.com> Content-Language: en-US From: Tiago Sousa In-Reply-To: <573493064.5243.1752160423097@webmail.proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_MSPIKE_H2 -0.01 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [eurotux.com] Just adding a few things I noticed during testing, on top of what Fabian=20 already mentioned: 1. VM data not wiped after deletion: When I delete a VM and then create a new one with the same settings, the=20 old OS and data are still there. It looks like the disk wasn't properly=20 cleaned up. 2. Can=E2=80=99t roll back to older snapshots: Rolling back only works for the latest snapshot. If I try to go back to=20 an earlier one, I get this error: TASK ERROR: can't rollback, 'test01' is not most recent snapshot on=20 'vm-104-disk-0.qcow2' 3. Rollback doesn't work for LVM-thin volumes: When trying to roll back a snapshot on an LVM-thin volume, it fails with: can't rollback snapshot for 'raw' volume --===============7302211058020382519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel --===============7302211058020382519==--