From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 22D241FF187 for ; Mon, 25 Aug 2025 11:36:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C0EDDF73; Mon, 25 Aug 2025 11:36:16 +0200 (CEST) Date: Mon, 25 Aug 2025 11:36:14 +0200 From: Wolfgang Bumiller To: Christian Ebner Message-ID: References: <20250822151239.634129-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250822151239.634129-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756114570506 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox] s3-client: drop to restrictive minimum length check in region schema X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" applied, thanks On Fri, Aug 22, 2025 at 05:12:39PM +0200, Christian Ebner wrote: > As reported in the community forum, the current minimum length of 3 > characters for regions to be set in the s3 endpoint configuration is > to restrictive, as at least OVH also allows 2 character regions [0]. > > The region regex pattern already limits the minimum input anyways, so > simply drop the currently set minimum length check. > > [0] https://help.ovhcloud.com/csm/en-public-cloud-storage-s3-location?id=kb_article_view&sysparm_article=KB0047384 > > Fixes: https://forum.proxmox.com/threads/170146/ > Signed-off-by: Christian Ebner > --- > proxmox-s3-client/src/api_types.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs > index c68d85ef..115b1d2d 100644 > --- a/proxmox-s3-client/src/api_types.rs > +++ b/proxmox-s3-client/src/api_types.rs > @@ -47,7 +47,6 @@ pub const S3_ENDPOINT_SCHEMA: Schema = StringSchema::new("Endpoint to access S3 > /// Region to access S3 object store. > pub const S3_REGION_SCHEMA: Schema = StringSchema::new("Region to access S3 object store.") > .format(&S3_REGION_FORMAT) > - .min_length(3) > .max_length(32) > .schema(); > > -- > 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel