From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 51CB31FF13F for ; Thu, 26 Mar 2026 14:47:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18581139CB; Thu, 26 Mar 2026 14:47:54 +0100 (CET) Date: Thu, 26 Mar 2026 14:47:49 +0100 From: Arthur Bied-Charreton To: Fiona Ebner , y@jett.proxmox.com Subject: Re: [PATCH pve-manager 1/8] ui: VMCPUFlagSelector: Fix unknownFlags behaviour Message-ID: References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-2-a.bied-charreton@proxmox.com> <33c11002-5ccb-4113-ab3d-565ea3b93a99@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33c11002-5ccb-4113-ab3d-565ea3b93a99@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774532821941 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.811 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XANV6NOHIRNP6OJTKCAQTAXD7JHYN3SL X-Message-ID-Hash: XANV6NOHIRNP6OJTKCAQTAXD7JHYN3SL X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Mar 25, 2026 at 04:57:42PM +0100, Fiona Ebner wrote: > Am 12.03.26 um 9:39 AM schrieb Arthur Bied-Charreton: > > ...and typo in name. > > > > Original patch: > > https://lore.proxmox.com/pve-devel/20211028114150.3245864-6-s.reiter@proxmox.com/ > > > > Pre-existing, but the commit message/title should describe what exactly > is fixed. Also, might be nicer to have the renaming be a separate commit. > ACK, will make this 2 commits and clarify the fix > > Originally-by: Stefan Reiter > > Signed-off-by: Arthur Bied-Charreton [...]