From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9B75D1FF164 for ; Fri, 28 Feb 2025 17:19:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51B9A13783; Fri, 28 Feb 2025 17:19:24 +0100 (CET) Date: Fri, 28 Feb 2025 17:19:20 +0100 From: Gabriel Goller To: Thomas Lamprecht Message-ID: Mail-Followup-To: Thomas Lamprecht , Proxmox VE development discussion References: <20250214133951.344500-1-g.goller@proxmox.com> <20250214133951.344500-4-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 28.02.2025 14:57, Thomas Lamprecht wrote: >Am 14.02.25 um 14:39 schrieb Gabriel Goller: >> This adds the intermediate, type-checked fabrics config. This one is >> parsed from the SectionConfig and can be converted into the >> Frr-Representation. > >The short description of the patch is good, but I would like to see more >rationale here about choosing this way, like benefits and trade-offs to other >options that got evaluated, if this can/will be generic for all fabrics planned, >..., and definitively some more rust-documentation for public types and modules. Yep, wrote together a small reasoning and will write some more documentation for public types. >One thing I noticed below, I did not managed to do a thorough review besides >of that yet though. >> [snip] >> +impl Hostname { >> + pub fn new(name: impl Into) -> Hostname { >> + Self(name.into()) >> + } >> +} >> + >> +// parses a bool from a string OR bool >> +pub mod serde_option_bool { > >might be maybe something to put in proxmox-serde? Yep, I agree. Thanks for the review! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel