From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pdm-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0AA4C1FF172 for <inbox@lore.proxmox.com>; Tue, 15 Apr 2025 08:44:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 288033F54E; Tue, 15 Apr 2025 08:44:18 +0200 (CEST) Date: Tue, 15 Apr 2025 08:44:14 +0200 From: Wolfgang Bumiller <w.bumiller@proxmox.com> To: Gabriel Goller <g.goller@proxmox.com> Message-ID: <gzpgygnjf6x3g3ba5kxuc2cuugfb7oim7evmpxn73kdqt3agfx@og2rsxkx23t4> References: <20250414120046.486853-1-g.goller@proxmox.com> <20250414120046.486853-2-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250414120046.486853-2-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH proxmox 1/3] section-config: make write_section_config parameter more generic X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion <pdm-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/> List-Post: <mailto:pdm-devel@lists.proxmox.com> List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Datacenter Manager development discussion <pdm-devel@lists.proxmox.com> Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com> style nit On Mon, Apr 14, 2025 at 02:00:43PM +0200, Gabriel Goller wrote: > The underlying function which gets called by `write_section_config` also > takes a `impl AsRef<Path>` and in some cases we do pass a path, so > taking the same parameter is better. > > Signed-off-by: Gabriel Goller <g.goller@proxmox.com> > --- > proxmox-section-config/src/typed.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/proxmox-section-config/src/typed.rs b/proxmox-section-config/src/typed.rs > index 31e8e4b2e546..a25798e8a29b 100644 > --- a/proxmox-section-config/src/typed.rs > +++ b/proxmox-section-config/src/typed.rs > @@ -1,6 +1,7 @@ > //! Support for `enum` typed section configs. > > use std::collections::HashMap; > +use std::path::Path; > > use anyhow::Error; > use serde::{de::DeserializeOwned, Serialize}; > @@ -90,7 +91,7 @@ pub trait ApiSectionDataEntry: Sized { > } > > /// Provided. Shortcut for `Self::section_config().write(filename, &data.try_into()?)`. > - fn write_section_config(filename: &str, data: &SectionConfigData<Self>) -> Result<String, Error> > + fn write_section_config(filename: impl AsRef<Path>, data: &SectionConfigData<Self>) -> Result<String, Error> - This is now too long (missing `fmt` call?) - I'd like to avoid too many `impl` parameters as they very quickly lead to very long lines, particularly... > where ...since we already have a `where` section here. With `filename: P` the signature still fits in into a single line with P: AsRef<Path>, here > Self: Serialize, > { > -- > 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel