From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C8EB41FF15C for ; Fri, 11 Jul 2025 10:26:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D46E8B258; Fri, 11 Jul 2025 10:27:20 +0200 (CEST) Date: Fri, 11 Jul 2025 10:27:17 +0200 From: Gabriel Goller To: Christian Ebner Message-ID: Mail-Followup-To: Christian Ebner , pve-devel@lists.proxmox.com References: <20250711080302.163858-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250711080302.163858-1-c.ebner@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [runenv.pm] Subject: Re: [pve-devel] [PATCH] run-env: fallback to all zero mac for interfaces without X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11.07.2025 10:03, Christian Ebner wrote: >The installer assumes to have a valid mac address for all interfaces >as provided by the runtime env json file. Deserialization will fail >if this is not the case. > >In some cases, the interface might however not provide a valid MAC >address, for example the WWAN module without any SIM installed on >some laptops. > >Fix this by defaulting to an all zero MAC address if non is detected. > >Signed-off-by: Christian Ebner >--- >Please note: Untested, but I can test it based on an iso installer on >affected hardware > > Proxmox/Install/RunEnv.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm >index e4f0eb0..d7ee258 100644 >--- a/Proxmox/Install/RunEnv.pm >+++ b/Proxmox/Install/RunEnv.pm >@@ -110,7 +110,7 @@ my sub query_netdevs : prototype() { > $ifs->{$name} = { > index => $index, > name => $name, >- mac => $mac, >+ mac => $mac // '00:00:00:00:00:00', > state => uc($state), > }; > $ifs->{$name}->{addresses} = \@valid_addrs if @valid_addrs; To be honest I'd rather filter out this interface. A zeroed out mac is reserved for loopback interfaces and usually isn't routed. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel