From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 764831FF13F for ; Thu, 26 Mar 2026 15:16:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E05821575A; Thu, 26 Mar 2026 15:17:15 +0100 (CET) Date: Thu, 26 Mar 2026 15:17:09 +0100 From: Arthur Bied-Charreton To: Fiona Ebner Subject: Re: [PATCH pve-manager 3/8] ui: CPUModelSelector: Allow filtering out custom models Message-ID: References: <20260312084021.124465-1-a.bied-charreton@proxmox.com> <20260312084021.124465-4-a.bied-charreton@proxmox.com> <5767941a-a9ff-4567-8511-57df6ec0dbc2@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5767941a-a9ff-4567-8511-57df6ec0dbc2@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774534581754 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.800 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MH3IU7XKP3MNUIIGVZUC6J3LEDWMAGZB X-Message-ID-Hash: MH3IU7XKP3MNUIIGVZUC6J3LEDWMAGZB X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Mar 26, 2026 at 10:59:24AM +0100, Fiona Ebner wrote: > Am 12.03.26 um 9:40 AM schrieb Arthur Bied-Charreton: > > Add 'allowCustom' configuration parameter. When set to false, only > > default CPU models will be shown. > > > > Original patch: > > https://lore.proxmox.com/pve-devel/20211028114150.3245864-8-s.reiter@proxmox.com/ > > > > Originally-by: Stefan Reiter > > Signed-off-by: Arthur Bied-Charreton > > --- > > www/manager6/form/CPUModelSelector.js | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js > > index 737b6ff4..2154ff46 100644 > > --- a/www/manager6/form/CPUModelSelector.js > > +++ b/www/manager6/form/CPUModelSelector.js > > @@ -19,7 +19,9 @@ Ext.define('PVE.form.CPUModelSelector', { > > autoSelect: false, > > > > deleteEmpty: true, > > - > > + config: { > > + allowCustom: true, > > Tiny nit: I' slightly prefer showCustom or even slightly more > showCustomModels > ACK, will update the variable name in the next iteration of the series > > + }, > > listConfig: { > > columns: [ > > { > > @@ -100,4 +102,11 @@ Ext.define('PVE.form.CPUModelSelector', { > > }, > > }, > > }, > > + initComponent: function () { > > + let me = this; > > + me.callParent(); > > + if (!me.allowCustom) { > > + me.getStore().addFilter({ filterFn: (rec) => !rec.data.custom }); > > + } > > + }, > > }); >