Re: [PATCH datacenter-manager 3/3] clippy: sdn-client: fix 'large size difference between variants' for error type

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

The problem here is actually in `proxmox-client` - its
`Error::TfaRequired` should be boxed.

You'll see the same clippy warning when running `cargo clippy
--all-features` in `proxmox.git`'s `proxmox-client/` dir.

On Wed, May 20, 2026 at 03:13:47PM +0200, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>     Not sure if we should just add an ignore instead
> 
>  server/src/sdn_client.rs | 27 ++++++++++++++++-----------
>  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> diff --git a/server/src/sdn_client.rs b/server/src/sdn_client.rs
> index 95e4d69b..f56519a6 100644
> --- a/server/src/sdn_client.rs
> +++ b/server/src/sdn_client.rs
> @@ -2,7 +2,7 @@ use std::error::Error as StdError;
>  use std::sync::Arc;
>  use std::time::Duration;
>  
> -use anyhow::{self, bail, Context};
> +use anyhow::{self, bail, format_err, Context};
>  
>  use futures::{future::join_all, stream::FuturesUnordered, StreamExt, TryFutureExt};
>  use pdm_api_types::{remotes::Remote, RemoteUpid};
> @@ -25,7 +25,7 @@ pub struct LockedSdnClient {
>  
>  #[derive(Debug)]
>  pub enum LockedSdnClientError {
> -    Client(proxmox_client::Error),
> +    Client(Box<proxmox_client::Error>),
>      Other(anyhow::Error),
>  }
>  
> @@ -49,7 +49,7 @@ impl std::fmt::Display for LockedSdnClientError {
>  
>  impl From<proxmox_client::Error> for LockedSdnClientError {
>      fn from(value: proxmox_client::Error) -> Self {
> -        Self::Client(value)
> +        Self::Client(Box::new(value))
>      }
>  }
>  
> @@ -219,15 +219,20 @@ impl<C> LockedSdnClients<C> {
>                          }
>                      }
>  
> -                    return match &error {
> -                        LockedSdnClientError::Client(proxmox_client::Error::Api(status, _msg))
> -                            if *status == 501 =>
> -                        {
> -                            bail!("remote {} does not support the sdn locking api, please upgrade to PVE 9 or newer!", remote.id)
> +                    return match error {
> +                        LockedSdnClientError::Client(error) => match *error {
> +                            proxmox_client::Error::Api(status_code, _msg) if status_code == 501 => {
> +                                Err(format_err!("remote {} does not support the sdn locking api, please upgrade to PVE 9 or newer!", remote.id))
> +                            }
> +                            _ => Err(error).with_context(|| format!(
> +                                "could not lock sdn configuration for remote {}",
> +                                remote.id
> +                            )),
>                          }
> -                        _ => Err(error).with_context(|| {
> -                            format!("could not lock sdn configuration for remote {}", remote.id)
> -                        }),
> +                        _ => Err(error).with_context(|| format!(
> +                            "could not lock sdn configuration for remote {}",
> +                            remote.id
> +                        )),
>                      };
>                  }
>              };
> -- 
> 2.47.3
> 
> 
> 
> 
> 

--