From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 6F08693384
for <pbs-devel@lists.proxmox.com>; Fri, 16 Sep 2022 12:16:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5C9082262D
for <pbs-devel@lists.proxmox.com>; Fri, 16 Sep 2022 12:16:20 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Fri, 16 Sep 2022 12:16:19 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8A1BA44480
for <pbs-devel@lists.proxmox.com>; Fri, 16 Sep 2022 12:08:42 +0200 (CEST)
Message-ID: <fffd64d5-3717-dfbe-64b1-1c96f1b3cdef@proxmox.com>
Date: Fri, 16 Sep 2022 12:08:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.13.0
Content-Language: en-US
To: pbs-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
References: <20220914105039.186907-1-m.heiserer@proxmox.com>
<20220914105039.186907-2-m.heiserer@proxmox.com>
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20220914105039.186907-2-m.heiserer@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.948 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -1.816 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow
setting a time on which prune happens
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 16 Sep 2022 10:16:50 -0000
Same nit for the commit title.
Am 14.09.22 um 12:50 schrieb Matthias Heiserer:
> @@ -726,6 +730,15 @@ Ext.onReady(function() {
> padding: '0 0 0 10',
> value: new Date(),
> },
> + {
> + xtype: 'timefield',
> + name: 'currentTime',
> + reference: 'currentTime',
> + fieldLabel: 'Time of prune',
I don't really like using "Time of prune" here, because the setting also
affects the schedule and doesn't feel in line with "Today". How about
"Today's time" or simply "Time"? Or we could use "Current date" and
"Current time".
There's AM/PM times in the drop-down suggestions here, which clashes
with the 24 hour format used in the rest of the simulator. Let's try to
keep it consistent.
> + allowBlank: false,
> + padding: '0 0 0 10',
> + value: new Date(),
> + },
> ],
> },
> ],