From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 51A50924F4
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 16:15:41 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 41B8166F7
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 16:15:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 16:15:10 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8DBBF43370
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 16:15:10 +0200 (CEST)
Message-ID: <fff69610-ad74-8928-f11d-9f60f0cdf7aa@proxmox.com>
Date: Mon, 12 Sep 2022 16:15:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101
Thunderbird/105.0
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
References: <20220912120008.1220711-1-s.hanreich@proxmox.com>
<20220912120008.1220711-3-s.hanreich@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220912120008.1220711-3-s.hanreich@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 2.045 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -4.101 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH qemu-server v2 1/1] fix #4228: add start
parameter to rollback endpoint for automatic restarting of VM
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 12 Sep 2022 14:15:41 -0000
Am 12/09/2022 um 14:00 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index d9ef201..8bdda11 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -4745,6 +4745,11 @@ __PACKAGE__->register_method({
> node => get_standard_option('pve-node'),
> vmid => get_standard_option('pve-vmid', { completion => \&PVE::QemuServer::complete_vmid }),
> snapname => get_standard_option('pve-snapshot-name'),
> + start => {
> + optional => 1,
> + type => 'string',
> + description => "whether the container should get restarted afterwards",
same as for cotainer: fix type, add default improve description, but please
also with s/container/VM/ here ;-)
> + },
> },
> },
> returns => {
> @@ -4764,9 +4769,16 @@ __PACKAGE__->register_method({
>
> my $snapname = extract_param($param, 'snapname');
>
> + my $start = extract_param($param, 'start');
same as pve-container w.r.t. param extraction need
> +
> my $realcmd = sub {
> PVE::Cluster::log_msg('info', $authuser, "rollback snapshot VM $vmid: $snapname");
> PVE::QemuConfig->snapshot_rollback($vmid, $snapname);
> +
> + if ($start) {
> + PVE::Cluster::log_msg('info', $authuser, "start VM $vmid");
same as my comment for the pve-container w.r.t adding a cluster log here:
iff, separate patch and done centrally, but we can omit that completely
for now too,
> + PVE::API2::Qemu->vm_start({ vmid => $vmid, node => $node });
> + }
> };
>
> my $worker = sub {