From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 05A8E1FF14C for ; Fri, 15 May 2026 11:21:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C969C12FE0; Fri, 15 May 2026 11:21:03 +0200 (CEST) Message-ID: Date: Fri, 15 May 2026 11:20:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v3 00/13] ui: split out disks and nics into grids From: Dominik Csapak To: pve-devel@lists.proxmox.com References: <20260515085349.1123127-1-d.csapak@proxmox.com> <5d16302a-e7d5-4204-8577-2ae5d2ec0548@proxmox.com> Content-Language: en-US In-Reply-To: <5d16302a-e7d5-4204-8577-2ae5d2ec0548@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778836823378 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X6OEWGG3I6CW4VH5M5VNDAMUAVL45KBK X-Message-ID-Hash: X6OEWGG3I6CW4VH5M5VNDAMUAVL45KBK X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/15/26 11:18 AM, Dominik Csapak wrote: > sorry this should have been v4, resending now.... > sorry, disregard that, i looked at the wrong series... v3 is correct here... > On 5/15/26 10:54 AM, Dominik Csapak wrote: >> This is basically a complete rework of the series. Since the need >> for having the buttons in all grids made things a bit more complicated >> than i anticipated. >> >> I factored out a few things, so it's easier to reuse (especially since i >> want to do the same thing for containers when we figured out if the >> style/layout/etc. fits) >> >> Sending again qemu only for now as i don't want to put in a lot of work >> before we know which direction this will take. >> >> I tried to keep most commits small so it's easier to see what the actual >> change are. >> >> NOTE: I took special care for the button enablement logic, but having >> a close >> look at that during review would make a lot of sense. >> >> changes from v2: >> * reorganized code/commits for the most part, so it doesn't make much >>    sense to compare it to the previous version >> >> changes from v1: >> * refactor some regexes/checks >> * fix some bugs I encountered during testing again >> >> Dominik Csapak (13): >>    ui: utils: factor out 'media=cdrom' check >>    ui: factor out the guest key nic regex check >>    ui: parser: qemu drive: allow '-' in key names >>    ui: add pending grid >>    ui: revert button: add parentXType and reloadCallback >>    ui: button: add config remove button >>    ui: qemu: hardware: wrap in container >>    ui: qemu: introduce hardware disk grid >>    ui: qemu: introduce hardware net grid >>    ui: qemu: hardware view: separate disks into own grid >>    ui: qemu: hardware view: separate nics into own grid >>    ui: qemu: hardware view: inline edit/remove/revert button in general >>      grid >>    ui: qemu: hardware view: inline 'add efi' menuitem >> >>   www/manager6/Makefile                 |   4 + >>   www/manager6/Parser.js                |   2 +- >>   www/manager6/Utils.js                 |  23 +- >>   www/manager6/button/ConfigRemove.js   |  74 +++ >>   www/manager6/button/Revert.js         |   8 +- >>   www/manager6/grid/PendingGrid.js      | 134 ++++ >>   www/manager6/lxc/Network.js           |   4 +- >>   www/manager6/qemu/BootOrderEdit.js    |  12 +- >>   www/manager6/qemu/CreateWizard.js     |   4 +- >>   www/manager6/qemu/HardwareDiskGrid.js | 213 ++++++ >>   www/manager6/qemu/HardwareNetGrid.js  |  81 +++ >>   www/manager6/qemu/HardwareView.js     | 925 +++++++++++++++----------- >>   www/manager6/window/GuestImport.js    |   2 +- >>   13 files changed, 1079 insertions(+), 407 deletions(-) >>   create mode 100644 www/manager6/button/ConfigRemove.js >>   create mode 100644 www/manager6/grid/PendingGrid.js >>   create mode 100644 www/manager6/qemu/HardwareDiskGrid.js >>   create mode 100644 www/manager6/qemu/HardwareNetGrid.js >> > > > > >