From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id DA5848B9EF
 for <pve-devel@lists.proxmox.com>; Fri, 26 Aug 2022 08:34:02 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id C83CD2CA83
 for <pve-devel@lists.proxmox.com>; Fri, 26 Aug 2022 08:33:32 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Fri, 26 Aug 2022 08:33:28 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A72D4325C;
 Fri, 26 Aug 2022 08:33:28 +0200 (CEST)
Message-ID: <ff27091e-e761-0504-14b9-f935cf8196aa@proxmox.com>
Date: Fri, 26 Aug 2022 08:33:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101
 Thunderbird/105.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 "DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>
References: <20220825092440.1810328-1-d.csapak@proxmox.com>
 <20220825092440.1810328-17-d.csapak@proxmox.com>
 <233a23bf-98bf-2a9a-30a9-beeb62f38986@groupe-cyllene.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <233a23bf-98bf-2a9a-30a9-beeb62f38986@groupe-cyllene.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.094 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [qemumigrate.pm]
Subject: Re: [pve-devel] [PATCH qemu-server v2 11/13] PVE/QemuMigrate: check
 for mapped resources on migration
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 26 Aug 2022 06:34:02 -0000

On 8/25/22 20:00, DERUMIER, Alexandre wrote:
> Le 25/08/22 à 11:24, Dominik Csapak a écrit :
>> they can only be migrated to nodes where there exists a mapping and if
>> the migration is done offline
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>    PVE/QemuMigrate.pm | 13 ++++++++++++-
>>    1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
>> index d52dc8d..d40beac 100644
>> --- a/PVE/QemuMigrate.pm
>> +++ b/PVE/QemuMigrate.pm
>> @@ -162,7 +162,7 @@ sub prepare {
>>    	$self->{vm_was_paused} = 1 if PVE::QemuServer::vm_is_paused($vmid);
>>        }
>>    
>> -    my $loc_res = PVE::QemuServer::check_local_resources($conf, 1);
>> +    my ($loc_res, $mapped_res, $not_allowed_nodes) = PVE::QemuServer::check_local_resources($conf, 1);
>>        if (scalar @$loc_res) {
>>    	if ($self->{running} || !$self->{opts}->{force}) {
>>    	    die "can't migrate VM which uses local devices: " . join(", ", @$loc_res) . "\n";
>> @@ -171,6 +171,17 @@ sub prepare {
>>    	}
>>        }
>>    
>> +    if (scalar @$mapped_res) {
>> +	my $not_available = $not_allowed_nodes->{$self->{node}};
>> +	if ($self->{running}) {
>> +	    die "can't migrate running VM which uses mapped devices: " . join(", ", @$mapped_res) . "\n";
>> +	} elsif (scalar @$not_available) {
>> +	    die "can't migrate to '$self->{node}': missing mapped devices" . join(", ", @$not_available) . "\n";
>> +	} else {
>> +	    $self->log('info', "migrating VM which uses mapped local devices");
>> +	}
>> +    }
>> +
> 
> I think I have found a bug, because $self->{running} is always 0 in
> prepare phase, as it's filled in abstract at the end of the prepare pahse
> 
> $self->{running} = $self->prepare($self->{vmid});
> 
> 
> That mean than the classic check_local_resources is also broken, and
> only work because we don't send force option.
> 
> 
> Instead $self->{running}, simply use $running
> 
> 

thats true (independent of my patches, but i'm not making it better here..)
thanks for finding!