From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5BD231FF15E for ; Mon, 24 Nov 2025 15:28:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9407F25158; Mon, 24 Nov 2025 15:28:11 +0100 (CET) Message-ID: Date: Mon, 24 Nov 2025 15:27:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20251124142107.6240-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20251124142107.6240-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763994423382 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" * ui: traffic-control: fix `users` field submission not sure how `submition` happened :P On 11/24/25 15:21, Hannes Laimer wrote: > We should not submit an empty string when no user is selected, this > trips up the API endpoint. > > Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list") > Reported-by: Robert Obkircher > Signed-off-by: Hannes Laimer > --- > www/window/TrafficControlEdit.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js > index 83b84ff5..7243f5b3 100644 > --- a/www/window/TrafficControlEdit.js > +++ b/www/window/TrafficControlEdit.js > @@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', { > name: 'users', > multiSelect: true, > allowBlank: true, > + skipEmptyText: true, > cbind: { > deleteEmpty: '{!isCreate}', > }, _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel