From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F110D1FF0B7 for ; Fri, 13 Nov 2026 09:13:41 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6B8642175D; Fri, 13 Nov 2026 09:13:40 +0100 (CET) Message-ID: Date: Fri, 13 Nov 2026 09:13:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v3 05/11] s3-client: honor response header directed retry delays To: pbs-devel@lists.proxmox.com References: <20261112180119.660923-1-c.ebner@proxmox.com> <20261112180119.660923-6-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20261112180119.660923-6-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794557614702 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.400 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BCV7VJLV7P6D6UTJS54RZRCFO6HLZRGR X-Message-ID-Hash: BCV7VJLV7P6D6UTJS54RZRCFO6HLZRGR X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/12/26 7:01 PM, Christian Ebner wrote: > S3 API servers can tell clients when they expect to have capacity > available again via the x-amz-retry-after header, given in > milliseconds. Retrying earlier is likely to fail again and only adds > load, so try to honor these delays on retry. > > Use the server's requested delay instead of the computed backoff, but > never wait less than the backoff and at most 5 seconds longer, so a > misbehaving server cannot stall requests for a long time. No jitter > is applied, the server is expected to randomize the delay itself. > > This follows the AWS SDKs implementation guide. > > Link: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.html > Signed-off-by: Christian Ebner Seems this is incomplete and it should check the Retry-After header as fallback as well. Some providers do not use x-amz-retry-after header, e.g. Backblaze B2 https://www.backblaze.com/docs/cloud-storage-rate-limits Will add this and send a new version of the patches.