From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D32641FF0B3 for ; Wed, 11 Nov 2026 14:19:10 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9F33221615; Wed, 11 Nov 2026 14:19:10 +0100 (CET) Message-ID: Date: Wed, 11 Nov 2026 14:19:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [RFC PATCH proxmox-backup 4/4] ui: tape restore: add selector for additional drives To: Jakob-Tobias Winter , pbs-devel@lists.proxmox.com References: <20261106133826.1692620-2-tobias@stuttgart.de> <20261106133826.1692620-6-tobias@stuttgart.de> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20261106133826.1692620-6-tobias@stuttgart.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794403146351 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.310 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UR27XQWCZ7ZDGQITP5U5XHBJQHNVEWAW X-Message-ID-Hash: UR27XQWCZ7ZDGQITP5U5XHBJQHNVEWAW X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: when changing to 'drives' instead, this patch would become just the change from `name: 'drive'` to `name: 'drives'` and add the multiselect, no? On 11/6/26 2:38 PM, Jakob-Tobias Winter wrote: > Allow choosing up to three more drives for a tape restore, to read > several media in parallel. > > Signed-off-by: Jakob-Tobias Winter > --- > www/tape/window/TapeRestore.js | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js > index 8ee4f17a9..d28d2f242 100644 > --- a/www/tape/window/TapeRestore.js > +++ b/www/tape/window/TapeRestore.js > @@ -374,6 +374,11 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', { > let controller = me.up('window').getController(); > let vm = controller.getViewModel(); > let datastores = []; > + > + let additionalDrives = values['additional-drives']; > + if (!additionalDrives || additionalDrives.length === 0) { > + delete values['additional-drives']; > + } > if (values.store.toString() !== '') { > let target = values.store.toString(); > delete values.store; > @@ -479,6 +484,16 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', { > fieldLabel: gettext('Drive'), > labelWidth: 120, > }, > + { > + xtype: 'pbsDriveSelector', > + name: 'additional-drives', > + fieldLabel: gettext('Additional Drives'), > + labelWidth: 120, > + multiSelect: true, > + allowBlank: true, > + skipEmptyText: true, > + emptyText: gettext('None'), > + }, > { > xtype: 'pbsDataStoreSelector', > name: 'store',