Re: [pbs-devel] [PATCH proxmox 2/2] pbs api types: add option to set GC chunk cleanup wait period

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 03.03.25 um 13:58 schrieb Fabian Grünbichler:
> On February 19, 2025 5:48 pm, Christian Ebner wrote: 
>> +pub const GC_WAIT_PERIOD_SCHEMA: Schema =
>> +    IntegerSchema::new("Wait period (in minutes) for garbage collection phase 2 chunk cleanup (default 24h 5m)")
>> +        .minimum(5)
>> +        .maximum(1445)
> 
> these seem a bit conservative - if we introduce the option, we could
> also allow to reduce the grace period to 0 or to require longer grace
> periods?

Would be fine by me to reducing the minimum to zero. And the extra 5
minutes are "just to be sure" safety-margin, not a requirement for
anything IIRC.


> wait period is also a bit of a misnomer IMHO, this is not something
> where we "wait" per se, but rather something to account for the
> timestamp information potentially not being accurate.. not sure what a
> better term would be, "grace period" doesn't really fit either..
> 
> it's a kind of "safety margin", maybe something related to that? naming
> can be quite hard..
> 
> maybe gc_atime_safety_margin ? that also implies that setting a
> non-default value has potential safety implications/risks your data,
> IMHO more than "reducing a wait period" does..

Maybe something with "cutoff", like just gc_cutoff or gc_atime_cutoff,
as a cut-off of which chunks we even consider for removal is basically
what this is.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel