From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id F002D6A6DE
 for <pve-devel@pve.proxmox.com>; Wed, 16 Mar 2022 15:32:52 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id E856E28CDD
 for <pve-devel@pve.proxmox.com>; Wed, 16 Mar 2022 15:32:52 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 54E1828CC6
 for <pve-devel@pve.proxmox.com>; Wed, 16 Mar 2022 15:32:52 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 098A546EAB
 for <pve-devel@pve.proxmox.com>; Wed, 16 Mar 2022 15:23:53 +0100 (CET)
Message-ID: <fbb178d6-9bc8-3e2b-9d7f-61865adcb42d@proxmox.com>
Date: Wed, 16 Mar 2022 15:23:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101
 Thunderbird/99.0
Content-Language: en-US
To: PVE development discussion <pve-devel@pve.proxmox.com>,
 Mira Limbeck <m.limbeck@proxmox.com>
References: <20200529122206.31787-1-m.limbeck@proxmox.com>
 <20200529122206.31787-3-m.limbeck@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20200529122206.31787-3-m.limbeck@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.058 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: [pve-devel] applied: [PATCH manager v2] change icmp type selector
 to a combogrid
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 16 Mar 2022 14:32:53 -0000

On 29.05.20 14:22, Mira Limbeck wrote:
> The combogrid contains all valid icmp types that iptables accepts. In
> addition to the names, the Type[/Code] value is shown as well. But
> specifying Type[/Code] is not supported.
> 
> As the simple solution with setStore() does not work to change the store
> for the combogrid, we simply have 2 different ICMPTypeSelectors, one for
> IPv4, the other for IPv6, which are switched depending on the specified
> protocol.
> 
> As disabled fields don't submit their value, we can keep the values for
> the dport and both icmp-type fields when switching protocols.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>  - rebased on master
>  - removed unnecessary name switching and removing of values on proto
>    switch
> 
>  www/manager6/grid/FirewallRules.js | 164 ++++++++++++++++++++++++++++-
>  1 file changed, 160 insertions(+), 4 deletions(-)
> 
>

applied, thanks!