From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D75A91F6E for <pve-devel@lists.proxmox.com>; Fri, 16 Feb 2024 11:15:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85B501F8FF for <pve-devel@lists.proxmox.com>; Fri, 16 Feb 2024 11:15:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 16 Feb 2024 11:15:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9ED2C48532 for <pve-devel@lists.proxmox.com>; Fri, 16 Feb 2024 11:15:04 +0100 (CET) Message-ID: <fab42876-e53e-44b8-ae0e-090a7ae2a8a7@proxmox.com> Date: Fri, 16 Feb 2024 11:15:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> To: pve-devel@lists.proxmox.com Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20231214094844.84950-1-l.wagner@proxmox.com> <c320f25b-ec97-4b1a-aba4-3a68e2edd046@proxmox.com> In-Reply-To: <c320f25b-ec97-4b1a-aba4-3a68e2edd046@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 16 Feb 2024 10:15:05 -0000 ping - still applies on master. Retested it quickly, also seems to work fine. On 1/8/24 11:43, Lukas Wagner wrote: > ping > > On 12/14/23 10:48, Lukas Wagner wrote: >> Deleting a built-in target/matcher does not remove it, but resets it >> to its default settings. This was not really obvious from the UI. >> This patch changes the 'Remove' button text based on the >> selected target/matcher. If it is a built-in, the button text is >> changed to 'Reset to default'. Also, if the built-in is not actually >> modified, the button is disabled. >> >> Lukas Wagner (2): >> remove button: allow to set custom confirmation message >> notify: change 'Remove' button to 'Reset to default' for built-ins >> >> src/button/Button.js | 10 ++++- >> src/panel/NotificationConfigView.js | 63 +++++++++++++++++++++++++++++ >> 2 files changed, 72 insertions(+), 1 deletion(-) >> > -- - Lukas