all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Samuel Rufinatscha <s.rufinatscha@proxmox.com>,
	Jakob-Tobias Winter <tobias@stuttgart.de>,
	pbs-devel@lists.proxmox.com
Subject: Re: [RFC PATCH proxmox-backup 05/12] tape: backup job: allow selecting groups by snapshot attributes
Date: Wed, 18 Nov 2026 16:19:15 +0100	[thread overview]
Message-ID: <f94cade7-385f-4fce-9d83-17870d31b194@proxmox.com> (raw)
In-Reply-To: <0ab4a114-3946-4855-842f-9a6dfb5ae1bf@proxmox.com>

On 11/18/26 2:07 PM, Samuel Rufinatscha wrote:
> On 11/13/26 10:06 AM, Jakob-Tobias Winter wrote:
>> Tape backup jobs can only select backup groups by type and ID so
>> far. Such filters have to be kept up to date by hand for every new
>> guest, and an ID says nothing about how important a guest is.
>>
>> Add an attribute filter to tape backup jobs. With a client which
>> stores the tags of a guest as snapshot attributes, production and
>> test guests can be written to different media pools with different
>> retention policies, by using one job for each media pool. The media
>> sets of the production guests then need fewer tapes and are faster
>> to restore.
>>
>> A group is included if it has one of the attributes given as include
>> filter, or if there are no include filters, and none of the
>> attributes given as exclude filter. The filter is applied in
>> addition to the group filter.
>>
>> Jobs without an attribute filter select the same groups as before.
>>
>> Signed-off-by: Jakob-Tobias Winter <tobias@stuttgart.de>
>> ---
>> A version without this patch cannot parse a tape-job.cfg in which the
>> new option is used (unknown property 'attribute-filter').
>>
>>   src/api2/config/tape_backup_job.rs |  8 ++++++++
>>   src/api2/tape/backup.rs            | 19 ++++++++++++++++---
>>   src/bin/proxmox-tape.rs            | 11 ++++++++---
>>   3 files changed, 32 insertions(+), 6 deletions(-)
>>
>> diff --git a/src/api2/config/tape_backup_job.rs b/src/api2/config/ 
>> tape_backup_job.rs
>> index 4bfc7f871..cb9e63ea6 100644
>> --- a/src/api2/config/tape_backup_job.rs
>> +++ b/src/api2/config/tape_backup_job.rs

[..]

>> @@ -391,6 +391,19 @@ fn backup_worker(
>>           None => group_list,
>>       };
>> +    let group_list = match &setup.attribute_filter {
>> +        Some(filters) => {
>> +            let mut filtered = Vec::new();
>> +            for group in group_list {
>> +                if AttributeFilter::apply_filters(filters, 
>> &group.attributes()?) {
> 
> once we filter for individual snapshots as suggested by @Christian,
> how should latest-only behave?
> 
> For example, if monday and tuesday are tagged with "test" and wednesday
> is tagged with "prod", should a test job copy the tuesday snapshot or
> skip the group because the latest backup in the group is on "prod"?

I lean towards handling this similar to verified-/encrypted-only is 
handled in sync jobs, where transfer-last is only applied after 
filtering [0]. That attribute filters are applied before cutoff via 
latest-only must then be documented explicitly.

> I would lean towards copying tuesday’s snapshot in this example since
> it’s the newest one and it matches the job’s filter

[0] 
https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=src/server/pull.rs;h=763fdb5d3bf873d68281ceca5f2e9abab385e196;hb=HEAD#l1204




  reply	other threads:[~2026-11-18 15:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  8:56 [RFC PATCH many 00/12] snapshot attributes for tags and pools of PVE guests, tape job filter Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH proxmox 01/12] pbs-api-types: add types and schemas for snapshot attributes Jakob-Tobias Winter
2026-11-16 14:57   ` Christian Ebner
2026-11-18 12:54   ` Samuel Rufinatscha
2026-11-13  8:56 ` [RFC PATCH proxmox 02/12] pbs-api-types: tape: add attribute filter to backup jobs Jakob-Tobias Winter
2026-11-16 14:57   ` Christian Ebner
2026-11-13  8:56 ` [RFC PATCH proxmox-backup 03/12] datastore: add attributes to backup snapshots Jakob-Tobias Winter
2026-11-16 14:57   ` Christian Ebner
2026-11-18 12:55   ` Samuel Rufinatscha
2026-11-13  8:56 ` [RFC PATCH proxmox-backup 04/12] fix #7452: api: datastore: add endpoints for snapshot attributes Jakob-Tobias Winter
2026-11-16 14:57   ` Christian Ebner
2026-11-13  8:56 ` [RFC PATCH proxmox-backup 05/12] tape: backup job: allow selecting groups by " Jakob-Tobias Winter
2026-11-18 13:06   ` Samuel Rufinatscha
2026-11-18 15:19     ` Christian Ebner [this message]
2026-11-13  8:56 ` [RFC PATCH proxmox-backup 06/12] ui: tape backup job: add attribute filter Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH proxmox-backup 07/12] docs: describe snapshot attributes and the tape job " Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH storage 08/12] pbs: add helper to set the attributes of a backup snapshot Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH guest-common 09/12] vzdump: add pbs-snapshot-attributes option Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH manager 10/12] vzdump: store guest tags and pool as snapshot attributes on PBS Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH manager 11/12] ui: backup job: add selector for PBS snapshot attributes Jakob-Tobias Winter
2026-11-13  8:56 ` [RFC PATCH docs 12/12] vzdump: describe snapshot attributes on Proxmox Backup Server Jakob-Tobias Winter
2026-11-16 14:57 ` [RFC PATCH many 00/12] snapshot attributes for tags and pools of PVE guests, tape job filter Christian Ebner
2026-11-18 13:07   ` Samuel Rufinatscha
2026-11-18 14:22 ` Samuel Rufinatscha
2026-11-19 11:58   ` Jakob-Tobias Winter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f94cade7-385f-4fce-9d83-17870d31b194@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.rufinatscha@proxmox.com \
    --cc=tobias@stuttgart.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal