From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4B1A81FF13A for ; Wed, 22 Jul 2026 14:02:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B450D214C9; Wed, 22 Jul 2026 14:02:09 +0200 (CEST) Message-ID: Date: Wed, 22 Jul 2026 14:01:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH backup v4 0/4] fix #7054: client: remove trailing newlines from credentials To: Maximiliano Sandoval , pbs-devel@lists.proxmox.com References: <20260706080246.108256-1-m.sandoval@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260706080246.108256-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784721668963 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.169 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M5H6MAOPOZ4LPFEA6I2UF3TXW6HJFL6K X-Message-ID-Hash: M5H6MAOPOZ4LPFEA6I2UF3TXW6HJFL6K X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/6/26 10:03 AM, Maximiliano Sandoval wrote: > See the first commit for more details. > > This was tested with proxmox-backup-client making a login/backup using different > credentials with and without newlines. The commands were similar to the > systemd-run commands at the Backup Client Usage docs. > > I did not find a way to create the keyfile with newlines in its password using > proxmox-backup-client since it reads from the tty stdin, but surely it could be > created manually. Perhaps it is safe-ish to also remove trailing control > characters from the encryption password but this seems a safer approach for now. > > Differences from v3: > - Move trim_end calls to get_password, get_repository, get_fingerprint > - Remove "in general" from the documentation > - Rename get_secret_impl to get_secret_string > > Diferences from v2: > - Reworded commit messages following feedback form v1. > > Diferences from v1: > - Always do an extra allocation to keep the code clean > - Rename password to blob > - Only strip newlines on passwords > Thanks for the new version of the patches, code is cleaner now IMO. Tested newlines and/or whitespaces are stripped as expected by adapting the respective systemd credentials files. Consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner