From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E59491FF165 for ; Thu, 6 Nov 2025 17:15:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03EFD1D53C; Thu, 6 Nov 2025 17:16:23 +0100 (CET) Message-ID: Date: Thu, 6 Nov 2025 17:15:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pbs-devel@lists.proxmox.com References: <20251105155129.517430-1-n.frey@proxmox.com> From: Nicolas Frey Content-Language: en-US In-Reply-To: <20251105155129.517430-1-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762445729894 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.788 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] superseded: [PATCH proxmox{, -backup} 0/5] parallelize chunk reads in verification X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Superseded-by: https://lore.proxmox.com/pbs-devel/20251106161316.528349-1-n.frey@proxmox.com/T/#t On 11/5/25 4:51 PM, Nicolas Frey wrote: > This patch series aims to expand on Dominik's series [0] written for > pbs 3, parallelizing chunk reads in `VerifyWorker` using a seperate > thread pool from the verification. > > The number of threads was previously hard-coded, but is now > configurable via the API and GUI with a new property called > `worker-threads`, similarly to tape backups. > > The number of `worker-threads` only controls the thread pool for > reading, though if it makes sense to reuse this for the verification > pool, it could be adjusted to do so too. > > In my local tests I measured the following speed difference: > verified a single snapshot with ~32 GiB (4x the RAM size) with 4 cores > > 1 thread: ~440MiB/s > 2 threads: ~780MiB/s > 4 threads: ~1140MiB/s > > [0] https://lore.proxmox.com/pbs-devel/20250707132706.2854973-1-d.csapak@proxmox.com/#t > > proxmox: > > Nicolas Frey (1): > pbs-api-types: jobs: verify: add worker-threads to > VerificationJobSetup > > pbs-api-types/src/jobs.rs | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > > proxmox-backup: > > Nicolas Frey (4): > api: verify: move chunk loading into parallel handler > api: verify: use worker-threads to determine the number of threads to > use > api: verify: add worker-threads to update endpoint > ui: verify: add option to set number of threads for job > > src/api2/admin/datastore.rs | 13 +++- > src/api2/backup/environment.rs | 2 +- > src/api2/config/verify.rs | 8 +++ > src/backup/verify.rs | 123 +++++++++++++++++++++------------ > src/server/verify_job.rs | 3 +- > www/window/VerifyAll.js | 12 ++++ > www/window/VerifyJobEdit.js | 13 ++++ > 7 files changed, 125 insertions(+), 49 deletions(-) > > > Summary over all repositories: > 8 files changed, 135 insertions(+), 49 deletions(-) > _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel