From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4E26D1FF13F for ; Thu, 12 Mar 2026 10:49:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 670EFCAF3; Thu, 12 Mar 2026 10:49:26 +0100 (CET) Message-ID: Date: Thu, 12 Mar 2026 10:49:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ha-manager 1/2] rules: ensure rule is defined and has type in set_rule_defaults To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260311125008.271334-1-d.kral@proxmox.com> <20260311125008.271334-2-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260311125008.271334-2-d.kral@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773308926148 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CW2EBQEKXUH5LDRRB4TBIGN3BO3AY6QP X-Message-ID-Hash: CW2EBQEKXUH5LDRRB4TBIGN3BO3AY6QP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Just a note for the future: please also include the bug number in the commit title, so it can also be seen in one-line git history. From the developer documentation [0]: If the commit fixes a bug start with that information in this form: fix #1234: summary here [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages Am 11.03.26 um 1:50 PM schrieb Daniel Kral: > If the rule is not defined or does not have a type set, there are no > optional property defaults to set. > > This prevents users of set_rule_defaults(...) to have to deal with > unnecessary error handling. > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7399 > Signed-off-by: Daniel Kral > --- > src/PVE/HA/Rules.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm > index 38c57548..3a14eeb3 100644 > --- a/src/PVE/HA/Rules.pm > +++ b/src/PVE/HA/Rules.pm > @@ -274,7 +274,8 @@ haven't been explicitly set yet. > sub set_rule_defaults { > my ($class, $rule) = @_; > > - if (my $plugin = $class->lookup($rule->{type})) { > + if ($rule && $rule->{type}) { > + my $plugin = $class->lookup($rule->{type}); > my $properties = $plugin->properties(); > > for my $prop (keys %$properties) {