From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7F6FF1FF14C for ; Fri, 15 May 2026 10:00:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44ED5F368; Fri, 15 May 2026 10:00:19 +0200 (CEST) Message-ID: Date: Fri, 15 May 2026 10:00:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: [PATCH manager/storage 0/2] fix #3936: add validation for ZFS blocksize To: pve-devel@lists.proxmox.com References: <20260512134852.142044-1-d.riley@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: <20260512134852.142044-1-d.riley@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778832009028 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.287 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm] Message-ID-Hash: DBN4Y2MRWOLDLVKXE66NWKJQPFP2SRG7 X-Message-ID-Hash: DBN4Y2MRWOLDLVKXE66NWKJQPFP2SRG7 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: superseded by: https://lore.proxmox.com/pve-devel/20260515075159.45099-1-d.riley@proxmox.com/ On 5/12/26 3:48 PM, David Riley wrote: > This patch series fixes #3936 [0] by implementing validation for the > ZFS blocksize parameter in both the backend API and the frontend UI. > > Currently, providing an invalid blocksize (e.g., a non-power-of-two or > a value outside the supported range) does not result in an immediate > API error and therefore delays the failure to the volume creation. > This patch series ensures that invalid configurations are caught > early. > > Validation [1][2]: > * Range: 512 bytes to 16 MiB. > * Format: Allow positive integers with optional 'k' or 'm' suffix. > * Constraint: Must be a power of two. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3936 > [1] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#volblocksize > [2] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#recordsize > > > pve-manager: > > David Riley (1): > fix #3936: ui: storage: add validation for ZFS blocksize > > www/manager6/Utils.js | 34 +++++++++++++++++++++++++++++ > www/manager6/storage/ZFSEdit.js | 1 + > www/manager6/storage/ZFSPoolEdit.js | 1 + > 3 files changed, 36 insertions(+) > > > pve-storage: > > David Riley (1): > fix #3936: api: add zfs-blocksize format > > src/PVE/Storage/Plugin.pm | 34 ++++++++++++++++++++++++++++++++ > src/PVE/Storage/ZFSPoolPlugin.pm | 1 + > 2 files changed, 35 insertions(+) > > > Summary over all repositories: > 5 files changed, 71 insertions(+), 0 deletions(-) >