From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7524272FCF for <pve-devel@lists.proxmox.com>; Wed, 25 May 2022 17:06:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6AEA62CFF8 for <pve-devel@lists.proxmox.com>; Wed, 25 May 2022 17:06:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E9BD62CFED for <pve-devel@lists.proxmox.com>; Wed, 25 May 2022 17:06:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A0DAB43853 for <pve-devel@lists.proxmox.com>; Wed, 25 May 2022 17:06:11 +0200 (CEST) Message-ID: <f76c316e-53e4-8133-b529-a87ec1f2b24f@proxmox.com> Date: Wed, 25 May 2022 17:06:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Daniel Tschlatscher <d.tschlatscher@proxmox.com> References: <20220520132859.144041-1-d.tschlatscher@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220520132859.144041-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.677 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.328 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [content.pm, storage.pm] Subject: Re: [pve-devel] [PATCH storage v3 1/4] fix #3972: Remove the .notes file when a backup is deleted X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 25 May 2022 15:06:12 -0000 On 20/05/2022 15:28, Daniel Tschlatscher wrote: > When a VM or Container backup was deleted, the .notes file was not > removed, therefore, over time the dump folder would get polluted with > notes for backups that no longer existed. As backup names contain a > timestamp and as the notes cannot be reused because of this, I think > it is safe to just delete them just like we do with the .log file. > > Furthermore, I sourced the deletion of the log and notes file into a > new function called "archive_auxiliaries_remove". Additionally, the > archive_info object now returns one more field containing the name of > the notes file. The test cases have to be adapted to expect this new > value as the package will not compile otherwise. > > Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com> > --- the "changes since v2" sections are missing from all patches, making it harder to check if all comments got addressed or what other changes there were... > PVE/API2/Storage/Content.pm | 5 ++--- > PVE/Storage.pm | 20 +++++++++++++++----- > test/archive_info_test.pm | 6 ++++++ > 3 files changed, 23 insertions(+), 8 deletions(-) >