From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id A1C9A63A02
for <pbs-devel@lists.proxmox.com>; Mon, 5 Oct 2020 16:52:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8FD911BD40
for <pbs-devel@lists.proxmox.com>; Mon, 5 Oct 2020 16:52:26 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 097F41BD36
for <pbs-devel@lists.proxmox.com>; Mon, 5 Oct 2020 16:52:26 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C671745480
for <pbs-devel@lists.proxmox.com>; Mon, 5 Oct 2020 16:52:25 +0200 (CEST)
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>
References: <20201005134317.12425-1-d.csapak@proxmox.com>
<20201005134317.12425-5-d.csapak@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <f6dbdc81-e717-19c0-647b-c37fcdd7ba54@proxmox.com>
Date: Mon, 5 Oct 2020 16:52:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101
Thunderbird/82.0
MIME-Version: 1.0
In-Reply-To: <20201005134317.12425-5-d.csapak@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.152 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 5/7] ui:
Dashboard/TaskSummary: refactor types and title
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 05 Oct 2020 14:52:56 -0000
On 05.10.20 15:43, Dominik Csapak wrote:
> by moving the definition into the controller and dynamically use them
> in the updateTasks function
>=20
> we will reuse/extend this later
>=20
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/dashboard/TaskSummary.js | 31 +++++++++++++++++++++----------
> 1 file changed, 21 insertions(+), 10 deletions(-)
>=20
> diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.j=
s
> index 0cf049cd..efbd011d 100644
> --- a/www/dashboard/TaskSummary.js
> +++ b/www/dashboard/TaskSummary.js
> @@ -7,6 +7,20 @@ Ext.define('PBS.TaskSummary', {
> controller: {
> xclass: 'Ext.app.ViewController',
> =20
> + types: [
> + "backup",
> + "prune",
> + "garbage_collection",
> + "sync",
> + ],
> +
> + titles: {
> + "backup": gettext('Backups'),
> + "prune": gettext('Prunes'),
> + "garbage_collection": gettext('Garbage collections'),
> + "sync": gettext('Syncs'),
> + },
> +
> render_icon: function(state, count) {
> let cls =3D 'question';
> let color =3D 'faded';
> @@ -42,16 +56,13 @@ Ext.define('PBS.TaskSummary', {
> =20
> updateTasks: function(data) {
> let me =3D this;
> - data.backup.type =3D gettext('Backups');
> - data.prune.type =3D gettext('Prunes');
> - data.garbage_collection.type =3D gettext('Garbage collections');
> - data.sync.type =3D gettext('Syncs');
> - me.lookup('grid').getStore().setData([
> - data.backup,
> - data.prune,
> - data.garbage_collection,
> - data.sync,
> - ]);
> + let controller =3D me.getController();
> + let data =3D [];
This introduces an linter error:
> [./dashboard/TaskSummary.js]:
> ERR : line 60 col 6: null - Parsing error: Identifier 'data' has alread=
y been declared
You're overwriting the function parameter "data" scope here.
> + controller.types.forEach((type) =3D> {
> + source[type].type =3D controller.titles[type];
"source" is not declared anywhere?
> + data.push(source[type]);
> + });
> + me.lookup('grid').getStore().setData(data);
> },
> =20
> layout: 'fit',
>=20