From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 406851FF15E for ; Mon, 1 Sep 2025 11:42:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE31B2ACD2; Mon, 1 Sep 2025 11:42:21 +0200 (CEST) Message-ID: Date: Mon, 1 Sep 2025 11:42:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion , vitalif@yourcmc.ru References: <45854bb6f7e2a5059e5b5472f85c64cc@yourcmc.ru> <1ff9fa45-752d-4935-a8b7-993096413749@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <1ff9fa45-752d-4935-a8b7-993096413749@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756719725097 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] Vitastor block driver plugin X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hi, Am 27.08.25 um 11:13 AM schrieb Thomas Lamprecht: > Hello, > > On 26/08/2025 16:42, vitalif@yourcmc.ru wrote: >> You've added a block device driver whitelist in Proxmox 9.0. > It's more intended for specific driver options, but as it die's if a > QEMU block device driver is not in the list it indeed also acts as > allow list for those. >> Could you please add Vitastor there? >> >> I mean this place: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage.pm;h=1dde2b751a766a28af8d40df7149936691cca772;hb=HEAD#l145 >> >> $allowed_qemu_blockdev_options in PVE/Storage.pm. >> >> For Vitastor to work correctly, it needs to contain: >> >> vitastor => { image => 1, 'config-path' => 1, 'etcd-host' => 1, 'etcd-prefix' => 1 } > > Hmm, we could add that, but would prefer only doing so if the plugin > is directly in QEMU already. That said, this is rather internal, so > maintenance cost would be low, so could be still fine... > I would like some other opinion on it though (CC @Fiona). I think it would also be nicer if it were an upstream QEMU block driver. Personally, I wouldn't mind including it in the allow-list, with a comment describing the situation, because the chances that another driver also using 'vitastor' as its name lands upstream first are very low. Am 28.08.25 um 12:58 AM schrieb vitalif@yourcmc.ru: > By the way, why did you add it in the first place? I thought these > options could only contain "trusted" values coming from PVE code > anyway? Or do some drivers really require filtering? It can also be third-party plugins. Some settings are handled via the VM configuration file and should not be set by the plugins, like cache mode, read-only, etc.. Many of the possible block drivers like job-related drivers also don't really make sense for the basic building block that qemu_blockdev_options() is supposed to return. Best Regards, Fiona _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel