From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D1EDFE553
for <pve-devel@lists.proxmox.com>; Tue, 18 Jul 2023 15:19:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id ACB8A1B76A
for <pve-devel@lists.proxmox.com>; Tue, 18 Jul 2023 15:19:54 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 18 Jul 2023 15:19:54 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A86342CED
for <pve-devel@lists.proxmox.com>; Tue, 18 Jul 2023 15:19:54 +0200 (CEST)
Message-ID: <f63f9eb8-a4c9-a27c-7ca8-07a389d05ee5@proxmox.com>
Date: Tue, 18 Jul 2023 15:19:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
References: <20230717150051.710464-1-l.wagner@proxmox.com>
<20230717150051.710464-9-l.wagner@proxmox.com>
<g6arhikjqpreaywuqmp7dfd7b7r5o6bulkxx4auzbt2mlm2god@woyywjppik6h>
Content-Language: en-US
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <g6arhikjqpreaywuqmp7dfd7b7r5o6bulkxx4auzbt2mlm2god@woyywjppik6h>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.102 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH v3 proxmox 08/66] notify: api: add API for
gotify endpoints
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2023 13:19:54 -0000
On 7/18/23 14:44, Wolfgang Bumiller wrote:
>> + }
>> +
>> + if super::endpoint_exists(config, &endpoint_config.name) {
>
> (*could* dedup the whole if into a helper in `super` so we don't need to
> copy-pasta the message to every new endpoint - we already have this
> twice now ;-) )
>
Yup, a later commit actually moves that to a common helper `super::ensure_unique`.
--
- Lukas