From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 7D0AF1FF166
for <inbox@lore.proxmox.com>; Fri, 25 Oct 2024 12:33:33 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A50BC1DC72;
Fri, 25 Oct 2024 12:33:32 +0200 (CEST)
Message-ID: <f62f04a5-6dc4-446d-957a-9734c7cd02d8@proxmox.com>
Date: Fri, 25 Oct 2024 12:32:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Christian Ebner <c.ebner@proxmox.com>
References: <20241018084242.144010-1-c.ebner@proxmox.com>
<20241018084242.144010-20-c.ebner@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20241018084242.144010-20-c.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.016 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v5 proxmox-backup 19/31] ui: group filter:
allow to set namespace for local datastore
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>
one nit inline (but no blocker for me IMHO)
On 10/18/24 10:42, Christian Ebner wrote:
> The namespace has to be set in order to get the correct groups to be
> used as group filter options with a local datastore as source,
> required for sync jobs in push direction.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 4:
> - no changes
>
> changes since version 3:
> - no changes
>
> www/form/GroupFilter.js | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/www/form/GroupFilter.js b/www/form/GroupFilter.js
> index c9c2d913e..7275b00ed 100644
> --- a/www/form/GroupFilter.js
> +++ b/www/form/GroupFilter.js
> @@ -258,7 +258,11 @@ Ext.define('PBS.form.GroupFilter', {
> return;
> }
> if (me.namespace) {
> - url += `?namespace=${me.namespace}`;
> + if (me.remote) {
> + url += `?namespace=${me.namespace}`;
> + } else {
> + url += `?ns=${me.namespace}`;
> + }
this not really possible to see from the context,
but imho this would be better suited in the if branches above,
e.g.
if (me.remote) {
url = ...;
if (me.namespace) {
url += ...;
}
} else {
...
}
that way the connection between the api call and the parameter is much more obvious
> }
> me.setDsStoreUrl(url);
> me.dsStore.load({
> @@ -279,6 +283,18 @@ Ext.define('PBS.form.GroupFilter', {
> }
> me.remote = undefined;
> me.datastore = datastore;
> + me.namespace = undefined;
> + me.updateGroupSelectors();
> + },
> +
> + setLocalNamespace: function(datastore, namespace) {
> + let me = this;
> + if (me.datastore === datastore && me.namespace === namespace) {
> + return;
> + }
> + me.remote = undefined;
> + me.datastore = datastore;
> + me.namespace = namespace;
> me.updateGroupSelectors();
> },
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel