From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C99701FF0C5 for ; Fri, 28 Aug 2026 10:11:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8945C2140C; Fri, 28 Aug 2026 10:11:03 +0200 (CEST) Message-ID: Date: Fri, 28 Aug 2026 10:10:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 proxmox-backup 0/2] minor chunk insert improvements To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260812135843.236667-1-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260812135843.236667-1-r.obkircher@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787904649915 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.705 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JQDQ76KFWY7R2UKP7XFHPARDOXSP4O2D X-Message-ID-Hash: JQDQ76KFWY7R2UKP7XFHPARDOXSP4O2D X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/12/26 3:58 PM, Robert Obkircher wrote: > Improve error messages and avoid custom unsafe code. > > Changes since [v1]: > * improve error messages as suggested by @Chris > * mention "magic number" > * reprase to "verify and garbage-collect" > > [v1] https://lore.proxmox.com/pbs-devel/20260807095803.3051-1-r.obkircher@proxmox.com/ > > Robert Obkircher (2): > datastore: prefer standard library over custom unsafe code > datastore: rephrase error messages for failed chunk insert > > pbs-datastore/src/chunk_store.rs | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > Acked-by: Christian Ebner