From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.laimer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C8682D50D
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 09:42:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A04E41D102
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 09:41:42 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 09:41:41 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 64D8648510
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 09:41:41 +0200 (CEST)
Message-ID: <f510130f-417f-9ea1-2ea1-d8889b3b1475@proxmox.com>
Date: Thu, 21 Sep 2023 09:41:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.15.1
Content-Language: en-US
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20230915065457.352953-1-h.laimer@proxmox.com>
<20230915065457.352953-4-h.laimer@proxmox.com>
<40808fbd-70c7-4c95-a335-67e079891345@proxmox.com>
From: Hannes Laimer <h.laimer@proxmox.com>
In-Reply-To: <40808fbd-70c7-4c95-a335-67e079891345@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.725 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -1.473 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 03/23] maintenance: add
'Unpplugged' maintenance type
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2023 07:42:12 -0000
On 9/19/23 15:37, Lukas Wagner wrote:
>
>
> On 9/15/23 08:54, Hannes Laimer wrote:
>> +
>> +#[test]
>> +fn test_check() {
>> + let ro_mode = MaintenanceMode::new(MaintenanceType::ReadOnly, None);
>> + let offline_mode = MaintenanceMode::new(MaintenanceType::Offline,
>> None);
>> + let delete_mode = MaintenanceMode::new(MaintenanceType::Delete,
>> None);
>> + let unplugged_mode =
>> MaintenanceMode::new(MaintenanceType::Unplugged, None);
>> +
>> + assert!(ro_mode.check(Some(Operation::Lookup)).is_ok());
>> + assert!(ro_mode.check(Some(Operation::Read)).is_ok());
>> + assert!(ro_mode.check(Some(Operation::Write)).is_err());
>> +
>> + assert!(offline_mode.check(Some(Operation::Lookup)).is_ok());
>> + assert!(offline_mode.check(Some(Operation::Read)).is_err());
>> + assert!(offline_mode.check(Some(Operation::Write)).is_err());
>> +
>> + assert!(delete_mode.check(Some(Operation::Lookup)).is_err());
>> + assert!(delete_mode.check(Some(Operation::Read)).is_err());
>> + assert!(delete_mode.check(Some(Operation::Write)).is_err());
>> +
>> + assert!(unplugged_mode.check(Some(Operation::Lookup)).is_err());
>> + assert!(unplugged_mode.check(Some(Operation::Read)).is_err());
>> + assert!(unplugged_mode.check(Some(Operation::Write)).is_err());
>> +}
>
> It's always advisable to have tests in separate submodule:
>
> #[cfg(test)]
> mod tests {
> use super::*;
>
> #[test]
> fn test_check() {
> ...
> }
> }
>
> This makes sure that the test(s) is/are not compiled during a normal
> build :)
>
Correct me if I'm wrong but, AFAIK `#[test]` does that, and since this
is the only and very simple test a whole mod thing seemed a bit
overkill, so I stuck with just `#[test]`.