From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5CF331FF143 for ; Mon, 02 Feb 2026 11:49:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 333DF15C3; Mon, 2 Feb 2026 11:50:17 +0100 (CET) Message-ID: Date: Mon, 2 Feb 2026 11:50:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 proxmox-backup 03/16] datastore: add TempTestDir that is automatically deleted on drop To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260130164552.281581-1-r.obkircher@proxmox.com> <20260130164552.281581-4-r.obkircher@proxmox.com> <109b44c9-e27c-4ebb-9ded-c1f57cc55987@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <109b44c9-e27c-4ebb-9ded-c1f57cc55987@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770029341159 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3UX3BA6ITG4NMA4MENUD7YDO5NX2FP2V X-Message-ID-Hash: 3UX3BA6ITG4NMA4MENUD7YDO5NX2FP2V X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/2/26 11:16, Christian Ebner wrote: > noticed just now that this also introduces a formatting error when > running `cargo fmt --check`.  What exactly is the error? It works on my machine, but there is a chance that I messed up my rustfmt version when I installed rustup with the newest nightly toolchain to run miri. (I found out miri doesn't support file backed mmap). I have: ~/dev/proxmox-backup$ git log --oneline -- pbs-datastore/src/temp_test_dir.rs f157c39e datastore: add TempTestDir that is automatically deleted on drop ~/dev/proxmox-backup$ cargo fmt --version rustfmt 1.8.0-nightly (de6d33c033 2026-01-28) ~/dev/proxmox-backup$ /usr/bin/cargo-fmt --version rustfmt 1.8.0 ~/dev/proxmox-backup$ cargo fmt --check ~/dev/proxmox-backup$ cargo fmt ~/dev/proxmox-backup$ git status On branch pipe nothing to commit, working tree clean