all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC v2 common 1/2] REST environment: add static log_warn function
Date: Wed, 16 Feb 2022 08:34:09 +0100	[thread overview]
Message-ID: <f3a10387-5ded-21db-b825-974e704c5b29@proxmox.com> (raw)
In-Reply-To: <20211029111624.142116-1-f.ebner@proxmox.com>

Ping for this series

Am 29.10.21 um 13:16 schrieb Fabian Ebner:
> which avoids the need for the caller to check whether the environment
> was initialized or not.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * The static function now calls the class method, rather than the
>       other way around. If the current environment is a derived class
>       providing its own implementation of warn(), the static function
>       will call that one.
> 
>  src/PVE/RESTEnvironment.pm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
> index 189a6cd..bf10040 100644
> --- a/src/PVE/RESTEnvironment.pm
> +++ b/src/PVE/RESTEnvironment.pm
> @@ -712,6 +712,17 @@ sub fork_worker {
>      return wantarray ? ($upid, $res) : $upid;
>  }
>  
> +sub log_warn {
> +    my ($message) = @_;
> +
> +    if ($rest_env) {
> +	$rest_env->warn($message);
> +    } else {
> +	chomp($message);
> +	print STDERR "WARN: $message\n";
> +    }
> +}
> +
>  sub warn {
>      my ($self, $message) = @_;
>  




  parent reply	other threads:[~2022-02-16  7:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 11:16 Fabian Ebner
2021-10-29 11:16 ` [pve-devel] [RFC v2 common 2/2] REST environment: allow export of log_warn Fabian Ebner
2022-03-04 10:33   ` [pve-devel] applied: " Thomas Lamprecht
2021-10-29 11:16 ` [pve-devel] [RFC v2 container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment Fabian Ebner
2022-03-04 10:25   ` Thomas Lamprecht
2022-03-04 10:32     ` Fabian Ebner
2022-03-04 10:40       ` Thomas Lamprecht
2022-12-14  8:23   ` Fiona Ebner
2022-12-14 11:14   ` [pve-devel] applied: " Thomas Lamprecht
2022-02-16  7:34 ` Fabian Ebner [this message]
2022-03-04 10:40 ` [pve-devel] applied: Re: [RFC v2 common 1/2] REST environment: add static log_warn function Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3a10387-5ded-21db-b825-974e704c5b29@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal