From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 61FE81FF13B for ; Wed, 20 May 2026 15:43:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3AC298D8; Wed, 20 May 2026 15:43:38 +0200 (CEST) Message-ID: Date: Wed, 20 May 2026 15:43:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260520124601.520864-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260520124601.520864-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779284567997 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: STEF64SPFWBKQ6CWYQUBEKIARLM6JWWI X-Message-ID-Hash: STEF64SPFWBKQ6CWYQUBEKIARLM6JWWI X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 20.05.26 um 14:45 schrieb Arthur Bied-Charreton: > Password manager extensions scan every new element. The flag > selector grid creates hundreds of radio buttons through its > widgetcolumn, causing the extension to peg the CPU while it checks each > one for autofill. > > Mark the radio inputs with autocomplete="off" and the extension-specific > ignore attributes so they are skipped during the scan. > > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/form/VMCPUFlagSelector.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index ea20108d..f8d4caad 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > boxLabelAlign: 'before', > inputValue: '-', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > checked: true, > inputValue: '=', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > { > boxLabel: '+', > inputValue: '+', > isFormField: false, > + inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', > }, > ], > }, oof, those plugins are not always a blessing... I'll skip this for now, as such changes can IME have slightly subtle effects, and besides that it would be nice to report this upstream where these plugins are developed, as IMO they should cope with that better (not that I expect it to happen soon, but still, if they don't know, they don't know). And if we have to go this route, I'd prefer avoiding some code duplication here by using defaults, i.e. doing something like: diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index ea20108da..e2e7c86ac 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -257,22 +257,24 @@ Ext.define('PVE.form.VMCPUFlagSelector', { //view.checkChange(); }, }, + defaults: { + isFormField: false, + inputAttrTpl: + 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"', + }, items: [ { boxLabel: '-', boxLabelAlign: 'before', inputValue: '-', - isFormField: false, }, { checked: true, inputValue: '=', - isFormField: false, }, { boxLabel: '+', inputValue: '+', - isFormField: false, }, ], },