Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 20.05.26 um 14:45 schrieb Arthur Bied-Charreton:
> Password manager extensions scan every new <input> element. The flag
> selector grid creates hundreds of radio buttons through its
> widgetcolumn, causing the extension to peg the CPU while it checks each
> one for autofill.
> 
> Mark the radio inputs with autocomplete="off" and the extension-specific
> ignore attributes so they are skipped during the scan.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  www/manager6/form/VMCPUFlagSelector.js | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ea20108d..f8d4caad 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>                          boxLabelAlign: 'before',
>                          inputValue: '-',
>                          isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                      },
>                      {
>                          checked: true,
>                          inputValue: '=',
>                          isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                      },
>                      {
>                          boxLabel: '+',
>                          inputValue: '+',
>                          isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                      },
>                  ],
>              },

oof, those plugins are not always a blessing... I'll skip this for now, as such
changes can IME have slightly subtle effects, and besides that it would be nice
to report this upstream where these plugins are developed, as IMO they should
cope with that better (not that I expect it to happen soon, but still, if they
don't know, they don't know).

And if we have to go this route, I'd prefer avoiding some code duplication here
by using defaults, i.e. doing something like:

diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index ea20108da..e2e7c86ac 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -257,22 +257,24 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
                         //view.checkChange();
                     },
                 },
+                defaults: {
+                    isFormField: false,
+                    inputAttrTpl:
+                        'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
+                },
                 items: [
                     {
                         boxLabel: '-',
                         boxLabelAlign: 'before',
                         inputValue: '-',
-                        isFormField: false,
                     },
                     {
                         checked: true,
                         inputValue: '=',
-                        isFormField: false,
                     },
                     {
                         boxLabel: '+',
                         inputValue: '+',
-                        isFormField: false,
                     },
                 ],
             },