From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7FD171FF165 for ; Thu, 17 Jul 2025 15:32:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF6333A986; Thu, 17 Jul 2025 15:34:00 +0200 (CEST) Message-ID: Date: Thu, 17 Jul 2025 15:33:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Hannes Laimer References: <20250716145216.175184-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20250716145216.175184-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752759206233 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v4 0/8] trigger sync jobs on mount X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/16/25 4:52 PM, Hannes Laimer wrote: > Sync jobs now have a run-on-mount flag, that, if set, runs the job whenever > a relevant removable datastore is mounted. > > changes since v3, thanks @Chris: > - wrap potentially blocking call to mount function in .spawn_blocking(|| > ...) > - ui: improve task title, delete `run-on-mount` flag iff `false` > - docs: add section about `run-on-mount` flag > - some minor things(typos, move stuff out of loop) > - rebased onto master > - ui: fixed formatting with `proxmox-biome` A few more comments on some individual patches, but nothing big. Other than that consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner Tested the following: - Sync jobs are executed when the config flag is set - The order of the executed sync jobs is alphabetical - The run-on-mount flag is cleared from the config when uncheck - The mount command via cli behaves the same as mounting via ui/api _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel