From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1338694468 for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:34:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC3B426AF0 for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:33:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:33:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9763846509 for <pve-devel@lists.proxmox.com>; Thu, 23 Feb 2023 16:33:53 +0100 (CET) Message-ID: <f362aae2-e4c3-d977-fd53-e0637e477878@proxmox.com> Date: Thu, 23 Feb 2023 16:33:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Matthias Heiserer <m.heiserer@proxmox.com> References: <20230130125751.170088-1-m.heiserer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230130125751.170088-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, drive.pm] Subject: [pve-devel] applied: [PATCH v2 qemu-server] api: ignore --efitype parameter when creating efidisk for ARM VM X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 23 Feb 2023 15:34:25 -0000 Am 30/01/2023 um 13:57 schrieb Matthias Heiserer: > Required because there's one single efi for ARM, and > the 2m/4m difference doesn't seem to apply. > > Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com> > --- > > Changes from v1: > Rather than change the efi type in the GUI, ignore it > in the API > > PVE/QemuServer.pm | 2 +- > PVE/QemuServer/Drive.pm | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > applied, thanks! But subject slightly reworded as it wasn't really in the api-specific part and having the efitype parameter include some CLI option hyphen included is not really useful when reading the git log. Also moved the description up to the actual efitype format string schema, fits better there as in the whole efidisk one - especially as this is only relevant for an unofficial niche architecture.