From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 33EFAE6F9
for <pbs-devel@lists.proxmox.com>; Tue, 26 Sep 2023 10:15:41 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0D9BD366AF
for <pbs-devel@lists.proxmox.com>; Tue, 26 Sep 2023 10:15:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Tue, 26 Sep 2023 10:15:10 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B0BE48D1A;
Tue, 26 Sep 2023 10:15:10 +0200 (CEST)
Message-ID: <f31588c3-5dba-47f8-a140-d015d0a0456c@proxmox.com>
Date: Tue, 26 Sep 2023 10:15:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>,
=?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
References: <20230921082157.33718-1-g.goller@proxmox.com>
<1695714131.wbzdf9yjca.astroid@yuna.none>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <1695714131.wbzdf9yjca.astroid@yuna.none>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.011 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH widget-toolkit] fix #4961: disks: increase
timeout to 1min
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 26 Sep 2023 08:15:41 -0000
On 9/26/23 09:55, Fabian Grünbichler wrote:
> On September 21, 2023 10:21 am, Gabriel Goller wrote:
>> Increase the timeout of the api call to `../nodes/localhost/disks/list`
>> to 1min. When having a lot of disks the default timeout of 30sec is
>> not enough.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> src/panel/DiskList.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
>> index c5a0050..5785297 100644
>> --- a/src/panel/DiskList.js
>> +++ b/src/panel/DiskList.js
>> @@ -70,6 +70,7 @@ Ext.define('Proxmox.DiskList', {
>> type: 'proxmox',
>> extraParams: extraParams,
>> url: url,
>> + timeout: 60*1000,
>
> that alone won't be enough, since we also have a 30s timeout for
> proxying requests in a PVE cluster (and this component is used there).
it would actually be enough to fix that exact bug, which is for pbs
where we don't have the 30s proxy limit, but you're right it's not
a generic fix across both products
imho we could still apply this here (maybe with a short test to
see if it doesn't make the situation worse for pve) so it's fixed
for pbs at least and can properly fix it for pve later still