From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 353D562290 for <pve-devel@lists.proxmox.com>; Sat, 11 Jul 2020 18:49:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 204FBD0E3 for <pve-devel@lists.proxmox.com>; Sat, 11 Jul 2020 18:49:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8E8D5D0C5 for <pve-devel@lists.proxmox.com>; Sat, 11 Jul 2020 18:49:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 549BE430C2 for <pve-devel@lists.proxmox.com>; Sat, 11 Jul 2020 18:49:17 +0200 (CEST) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com> References: <20200710181128.30097-1-s.ivanov@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <f12f01b7-053c-850b-bb4e-8c21c1ca6f7d@proxmox.com> Date: Sat, 11 Jul 2020 18:49:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200710181128.30097-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [guesthelpers.pm] Subject: [pve-devel] applied: Re: [PATCH guest-common] fix #2834: skip refs in config_with_pending_array X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Sat, 11 Jul 2020 16:49:48 -0000 On 10.07.20 20:11, Stoiko Ivanov wrote: > With the refactoring of config_with_pending_array in > daf8fca57a34417365c873ed91f3a52bf0002a4f a few sanity checks on parsed configs > were dropped. > > One case where a config value should be skipped, instead of parsed and added > is when the value is not scalar. This is the case for the raw lxc keys > (e.g. lxc.init.cmd, lxc.apparmor.profile) - which get added as array to the > 'lxc' key. > > This patch reintroduces the skipping of non-scalar values, when parsing the > config but not for the pending values. > From a short look through the commit history the sanity checks were in place > since 2014 (introduced in qemu-server for handling pending configuration > changes), and their removal did not cause any other regressions. > To my knowledge only the raw lxc config keys are parsed into a non-scalar > value. > > Tested by adding a 'lxc.init.cmd' key to a container config. > > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > I hope that I did not miss another case where the sanity-checks are necessary, > and can gladly send a v2 reintroducing all of them. > > PVE/GuestHelpers.pm | 2 ++ > 1 file changed, 2 insertions(+) > > applied, many thanks! Added a comment as followup, as during the refactoring Oguz had some feeling that there was something else besides snapshots but could not come up with anything, so I've thrown it out. Vetter safe than sorry (twice).